[Documentation] services.yml didn't match CharacterResolver
#161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Service must not be container aware.
mcg-web
approved these changes
Jun 19, 2017
There was a problem hiding this comment.
Thank you @martijngastkemper 👍 . but both are correct, the container is injected for resolvers implementing Symfony\Component\DependencyInjection\ContainerAwareInterface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
services.ymlthe type resolver is an argument, butCharacterResolverdoesn't have a__constructto handle that argument. It does work, becauseCharacterResolveris container aware. Replacing container aware by a construct makes the class look nice and the example more clear.