Skip to content

Conversation

renatomefi
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Documented? no
Fixed tickets #193
License MIT

It's still a bit restrictive, but as I can see there is no branch for 0.12. I suggest to keep an eye on the library release cycle and try to align it.
Since their objective is to keep versioning in sync with the JS library wouldn't be hard to keep track of it

Copy link
Contributor

@mcg-web mcg-web left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me but you are also using php 7.1 for your new build that is the trigger of php-coveralls. maybe we should consider adding a special env var for this case...

@mcg-web mcg-web merged commit 64690f2 into overblog:master Sep 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants