Allow using project composer Classloader and some more optimizations #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mcg-web
commented
Sep 21, 2017
mcg-web
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Documented? | yes |
| Fixed tickets | #189 |
| License | MIT |
mcg-web
force-pushed
the
optimizations
branch
from
8bf7f88 to
83c55fd
Compare
added 4 commits
September 22, 2017 08:34
also fix default resolver when using php types
mcg-web
force-pushed
the
optimizations
branch
from
83c55fd to
7d03b9a
Compare
renatomefi
reviewed
Sep 22, 2017
| if (null === $mapClassLoader) { | ||
| $mapClassLoader = new ClassLoader(); | ||
| $mapClassLoader->setClassMapAuthoritative(true); | ||
| } else { |
There was a problem hiding this comment.
Is it possible to enter this else statement? $mapClassLoader seems to be always null to me or am I missing something?
There was a problem hiding this comment.
No it is null on init because $mapClassLoader is declare as static so after it init it always has the same instance of ClassLoader.
| env: SYMFONY_VERSION=3.2.* | ||
| - php: 7.1 | ||
| env: SYMFONY_VERSION=3.3.* SCRUTINIZER=true | ||
| env: SYMFONY_VERSION=3.3.* TEST_COVERAGE=true |
| { | ||
| $config = $container->getParameter('overblog_graphql_types.config'); | ||
| $generatedClasses = $container->get('overblog_graphql.cache_compiler')->compile($this->processConfig($config)); | ||
| $generatedClasses = $container->get('overblog_graphql.cache_compiler')->compile( |
There was a problem hiding this comment.
I think it's a good idea to extract $container->get('overblog_graphql.cache_compiler') and check its type just for safety and the IDE will also type hint it nicely
mcg-web
force-pushed
the
optimizations
branch
from
1ad4348 to
4d1fb07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.