GraphQLController as a Service #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mcg-web could you help me with the tests? |
|
@renatomefi It seems like the service i not properly loaded, I'll give look to this Monday morning, this weekend I'm some way busy 💃 |
mcg-web
requested changes
Oct 16, 2017
Resources/config/routing/graphql.yml
Outdated
| path: / | ||
| defaults: | ||
| _controller: OverblogGraphQLBundle:Graph:endpoint | ||
| _controller: overblog_graphql.controller.graphql:endpoint |
There was a problem hiding this comment.
Add Action suffix the method name is not complete
Resources/config/routing/graphql.yml
Outdated
| path: /batch | ||
| defaults: | ||
| _controller: OverblogGraphQLBundle:Graph:batchEndpoint | ||
| _controller: overblog_graphql.controller.graphql:batchEndpoint |
Resources/config/routing/graphql.yml
Outdated
| path: /graphql/{schemaName} | ||
| defaults: | ||
| _controller: OverblogGraphQLBundle:Graph:endpoint | ||
| _controller: overblog_graphql.controller.graphql:endpoint |
Resources/config/routing/graphql.yml
Outdated
| path: /graphql/{schemaName}/batch | ||
| defaults: | ||
| _controller: OverblogGraphQLBundle:Graph:batchEndpoint | ||
| _controller: overblog_graphql.controller.graphql:batchEndpoint |
Resources/config/services.yml
Outdated
|
|
||
| overblog_graphql.controller.graphql: | ||
| class: Overblog\GraphQLBundle\Controller\GraphController | ||
| public: false |
There was a problem hiding this comment.
Controller services must be public
Controller/GraphController.php
Outdated
| use Symfony\Component\HttpFoundation\Response; | ||
|
|
||
| class GraphController extends Controller | ||
| final class GraphController |
There was a problem hiding this comment.
I'm not for controller as final but this is not part of the issue :)
|
push wrong button 🥇 |
renatomefi
force-pushed
the
refactor/graphcontroller
branch
from
d90477c to
1bfcad7
Compare
renatomefi
force-pushed
the
refactor/graphcontroller
branch
from
1bfcad7 to
70b9d8a
Compare
mcg-web
approved these changes
Oct 16, 2017
|
@mcg-web thanks a lot, your tips were directly to the point! It's working now! :) |
|
Nice, don't forget to remove wip label if you want it to be merge :) |
|
@mcg-web sure, I think that was it :) |
|
@renatomefi thank you for contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.