Allow Symfony 4.x as valid Symfony version #213
Conversation
| @@ -42,7 +44,7 @@ install: composer update --prefer-source --no-interaction --optimize-autoloader | |||
|
|
|||
| script: | |||
| - bin/phpunit --debug $( if [ $TEST_COVERAGE = true ]; then echo "-d xdebug.max_nesting_level=1000 --coverage-clover=build/logs/clover.xml"; fi; ) | |||
| - if [ ${TRAVIS_PHP_VERSION} == "7.0" ]; then bin/php-cs-fixer fix --diff --dry-run -v; fi; | |||
| - if [ ${TRAVIS_PHP_VERSION} == "7.0" ]; then composer require --dev 'friendsofphp/php-cs-fixer:^2.0' && bin/php-cs-fixer fix --diff --dry-run -v; fi; | |||
There was a problem hiding this comment.
Good idea! Let's make it run on 7.1 instead for speed?
There was a problem hiding this comment.
remove it from requirements because it seems to not be compatible with Symfony 4
.travis.yml
Outdated
| - php: nightly | ||
| env: COMPOSER_UPDATE_FLAGS=--ignore-platform-reqs | ||
| env: SYMFONY_VERSION=4.0.* DEPENDENCIES=dev COMPOSER_UPDATE_FLAGS=--ignore-platform-reqs |
There was a problem hiding this comment.
Let's make a build 7.1 with symfony 4 and leave the nightly more accordingly to our composer.json?
There was a problem hiding this comment.
yes, I will make the change
| @@ -7,7 +7,7 @@ overblog_graphql: | |||
| class_namespace: "Overblog\\GraphQLBundle\\Exception\\__DEFINITIONS__" | |||
| exceptions: | |||
| errors: | |||
| - "InvalidArgumentException" | |||
| - 'InvalidArgumentException' | |||
There was a problem hiding this comment.
Is this necessary? Feels like we are now mixing single and double quotes, maybe we can choose one
There was a problem hiding this comment.
nope no necessary, forget to rollback this
mcg-web
force-pushed
the
symfony_4
branch
2 times, most recently
from
3068be7 to
a4df733
Compare
| @@ -16,5 +16,6 @@ Giving some love to PHP CS | |||
| --------------------------- | |||
|
|
|||
| ```bash | |||
| bin/php-cs-fixer fix ./ | |||
| composer require --dev 'friendsofphp/php-cs-fixer:^2.0' | |||
There was a problem hiding this comment.
@mcg-web how about creating a composer script to install and run the php cs?
composer cs-fix
Could even do a composer test as well for the phpunit call
There was a problem hiding this comment.
I'm not against, we will dedicate a PR to this
|
@pascaldevink it seems that this is asking some more work to be ready to merge, I'm working on this thank for initializing the work 👍 |
|
Yeah, I've tried it myself a couple of weeks ago when making the SF Flex thingy, there's indeed some work necessary! Maybe this is a 0.11.0 thing? |
|
I would definitely argue that this requires a new version, this seems to be more than a patch, if only because php 5.5 is no longer supported. It seems all the tests that fail are for hhvm and php 5.6 with symfony 3.1, is there anything I can do to help fix these? |
|
The issue with this update is the change of container cache compilation as now each service are become a php file against methods in older versions... This new feature hardly touching the way the tests works right now. Some reverse engineering is necessary to understand this. |
It's time to move forward :D
Since Symfony released the first beta for version 4, which is not all that different from version 3.4, this composer change will allow it to work with that version (if the
minimum-stabilityis set tobetaat least).