Explicit types generation #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcg-web
force-pushed
the
explicit_types_generation
branch
4 times, most recently
from
4c6355e to
2a9de89
Compare
hgraca
suggested changes
Nov 6, 2017
There was a problem hiding this comment.
I would really change the command name.
Optionally, I would also reorganize the commits before merging. (first the code to change how/when the types are generated, together with the tests, then the command to trigger it via the command line, together with the tests, then the option to disable the auto generation, together with the tests)
Command/GeneratorCommand.php
Outdated
| { | ||
| $this | ||
| ->setName('graphql:generator') | ||
| ->setDescription('Execute manually types generation.') |
There was a problem hiding this comment.
compiler is a subject, a thing.
compile is a command, an action, something to do.
I would rename this to 'graphql:compile'
I would also change the description to Manually generate types or Generate types manually
There was a problem hiding this comment.
this make sense, thanks for review
mcg-web
force-pushed
the
explicit_types_generation
branch
3 times, most recently
from
c645ea0 to
7a27010
Compare
mcg-web
force-pushed
the
explicit_types_generation
branch
from
7a27010 to
5d4528e
Compare
barduck007
approved these changes
Nov 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.