Skip to content

Fix config files deep merges #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2016
Merged

Fix config files deep merges #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 9 additions & 18 deletions DependencyInjection/OverblogGraphQLTypesExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,16 +73,11 @@ public function containerPrependExtensionConfig(array $config, ContainerBuilder
*/
private function prependExtensionConfigFromFiles($type, $files, ContainerBuilder $container)
{
$typesConfig = [];
/** @var SplFileInfo $file */
foreach ($files as $file) {
$typesConfig = array_merge(
$typesConfig,
'yml' === $type ? $this->typesConfigFromYml($file, $container) : $this->typesConfigFromXml($file, $container)
);
$typeConfig = 'yml' === $type ? $this->typesConfigFromYml($file, $container) : $this->typesConfigFromXml($file, $container);
$container->prependExtensionConfig($this->getAlias(), $typeConfig);
}

$container->prependExtensionConfig($this->getAlias(), $typesConfig);
}

private function typesConfigFromXml(SplFileInfo $file, ContainerBuilder $container)
Expand Down Expand Up @@ -158,11 +153,9 @@ private function typesConfigsMappingFromBundles(ContainerBuilder $container)
$configPath = $bundleDir.'/'.$this->getMappingResourceConfigDirectory();
$params = $this->detectConfigFiles($container, $configPath);

if (null === $params) {
continue;
if (null !== $params) {
$typesMappings[] = $params;
}

$typesMappings[] = $params;
}

return $typesMappings;
Expand All @@ -188,14 +181,12 @@ private function detectConfigFiles(ContainerBuilder $container, $configPath, $ty
} catch (\InvalidArgumentException $e) {
continue;
}
if (0 === $finder->count()) {
continue;
if ($finder->count() > 0) {
return [
'type' => $type,
'files' => $finder,
];
}

return [
'type' => $type,
'files' => $finder,
];
}

return;
Expand Down