Feature/remove relay version option #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renatomefi
force-pushed
the
feature/remove-relay-version-option
branch
from
0d2ec3c to
04c5569
Compare
mcg-web
reviewed
Nov 28, 2017
| use Symfony\Component\Console\Output\OutputInterface; | ||
| use Symfony\Component\Console\Style\SymfonyStyle; | ||
| use Symfony\Component\DependencyInjection\ContainerInterface; | ||
|
|
There was a problem hiding this comment.
Why this should be final ? I'm not against final classes just want to understand why.
There was a problem hiding this comment.
It's not a must, but I think it's important to do it when we maintain a library, this way we don't promote users to extend certain things we don't want them to. When you leave it open you create some sort of legacy and can make some users suffer to update.
Now if they want to extend it they'll have to create a new command with their behavior, which I think is for their and our advantage!
mcg-web
approved these changes
Nov 28, 2017
|
Thank you @renatomefi ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO