Skip to content

Conversation

vbelorus
Copy link

@vbelorus vbelorus commented Jan 4, 2018

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? no
Documented? no
Fixed tickets
License MIT

Hi there.
I think using interfaces in __construct parameters will be better. I want to override parser but cannot do that without this changes.

Test not passed with and without my changes.

RuntimeException: Type class for alias "RootQuery" could not be load. If you are using your own classLoader verify the path and the namespace please.
Class 'Overblog\GraphQLBundle\Access\__DEFINITIONS__\RootQueryType' not found
ERRORS!
Tests: 254, Assertions: 492, Errors: 10.

Remaining deprecation notices (1)

Autowire custom tagged (type, resolver or mutation) services is deprecated as of 0.9 and will be removed in 1.0. Use AutoMapping or set it manually instead: 1x
    1x in ResolverTaggedServiceMappingPassTest::testCompilationWorksPassConfigDirective from Overblog\GraphQLBundle\Tests\DependencyInjection\Compiler

@vbelorus vbelorus changed the base branch from master to 0.10 January 4, 2018 07:53
Copy link
Contributor

@mcg-web mcg-web left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @vbelorus.

@mcg-web mcg-web merged commit c96e89b into overblog:0.10 Jan 4, 2018
@vbelorus vbelorus deleted the graphcontroller-constructor-fix branch January 4, 2018 08:17
@vbelorus
Copy link
Author

vbelorus commented Jan 4, 2018

@mcg-web thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants