Dump schema: Adds option to export schema with descriptions #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adri
force-pushed
the
feature/dump-schema-including-descriptions
branch
2 times, most recently
from
6968b13 to
0b2d252
Compare
adri
changed the title
adri
force-pushed
the
feature/dump-schema-including-descriptions
branch
from
0b2d252 to
5d1ecbb
Compare
adri
changed the title
mcg-web
requested changes
Apr 9, 2018
Command/GraphQLDumpSchemaCommand.php
Outdated
| ->addOption( | ||
| 'with-descriptions', | ||
| null, | ||
| InputOption::VALUE_OPTIONAL, |
There was a problem hiding this comment.
replace by InputOption::VALUE_NONE please
Command/GraphQLDumpSchemaCommand.php
Outdated
| null, | ||
| InputOption::VALUE_OPTIONAL, | ||
| 'Dump schema including descriptions.', | ||
| false |
Command/GraphQLDumpSchemaCommand.php
Outdated
| @@ -74,13 +81,14 @@ private function createFile(InputInterface $input) | |||
| { | |||
| $format = strtolower($input->getOption('format')); | |||
| $schemaName = $input->getOption('schema'); | |||
| $includeDescription = (bool) $input->getOption('with-descriptions'); | |||
There was a problem hiding this comment.
-$includeDescription = (bool) $input->getOption('with-descriptions');
+$includeDescription = $input->getOption('with-descriptions');
adri
force-pushed
the
feature/dump-schema-including-descriptions
branch
from
5d1ecbb to
6fec004
Compare
|
Thnx all done! |
mcg-web
approved these changes
Apr 9, 2018
|
Thanks! |
|
Awesome, thanks @adri |
|
Is there a reason for this option? To me this looks like something that should be always active. In case you don't need the descriptions you can simply ignore them when processing the json. |
|
The command was created to provide an instrospection json file for GraphQL Relay on compilation time, description is not an useful information in this case. That's the reason why this is optional. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
with-descriptionsoption to thegraphql:dump-schemacommand.