Skip to content

Allow webonyx/graphql-php 0.12 #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2018
Merged

Allow webonyx/graphql-php 0.12 #335

merged 1 commit into from
May 31, 2018

Conversation

mcg-web
Copy link
Contributor

@mcg-web mcg-web commented May 30, 2018

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Documented? no
Fixed tickets none
License MIT

renatomefi
renatomefi reviewed May 30, 2018
View reviewed changes
Copy link
Contributor

@renatomefi renatomefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, but indeed I think adding the 0.11 to the test matrix to make sure backwards compatibility is still working is essential before merging this!

@mcg-web mcg-web force-pushed the allow_graphql-php_0.12 branch 2 times, most recently from 7bad1d5 to a0d30db Compare May 30, 2018 18:42
@mcg-web mcg-web added the wip label May 30, 2018
@mcg-web
Copy link
Contributor Author

mcg-web commented May 30, 2018

Yes you right @renatomefi but since graphql language comments change between 0.11 and 0.12 it kind of difficult to tests both.

@mcg-web mcg-web force-pushed the allow_graphql-php_0.12 branch 4 times, most recently from 9df8fd5 to 169badc Compare May 30, 2018 20:37
@mcg-web mcg-web force-pushed the allow_graphql-php_0.12 branch from 169badc to 3c336ca Compare May 30, 2018 20:46
@mcg-web mcg-web removed the wip label May 30, 2018
@mcg-web mcg-web merged commit 70600bf into overblog:0.11 May 31, 2018
@mcg-web mcg-web deleted the allow_graphql-php_0.12 branch May 31, 2018 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barduck007 barduck007 barduck007 approved these changes

+1 more reviewer

@renatomefi renatomefi renatomefi left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcg-web @renatomefi @barduck007