Skip to content

Conversation

OwlyCode
Copy link
Contributor

@OwlyCode OwlyCode commented Jul 17, 2018

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Documented? not applicable
Fixed tickets no issue opened
License MIT

I encountered an issue with some complex access expressions :

"@=isAuthenticated() && (getUser().getId() == value.getId())"

Would mess with operator priorities by getting compiled to :

'access' => function ($value, $args, $context, ResolveInfo $info, $object) use ($globalVariable) {
    return ($globalVariable->get('container')->get('security.authorization_checker')->isGranted('IS_AUTHENTICATED_REMEMBERED') || $globalVariable->get('container')->get('security.authorization_checker')->isGranted('IS_AUTHENTICATED_FULLY') && (\Overblog\GraphQLBundle\ExpressionLanguage\ExpressionFunction\Security\Helper::getUser($globalVariable)->getId() == $value->getId()));
},

@mcg-web mcg-web changed the base branch from master to 0.11 July 18, 2018 05:18
@mcg-web mcg-web changed the base branch from 0.11 to master July 18, 2018 05:19
@mcg-web
Copy link
Contributor

mcg-web commented Jul 18, 2018

Hi @OwlyCode thank you for contribution! Can you change PR base on 0.10 branch please?

@OwlyCode OwlyCode changed the base branch from master to 0.10 July 18, 2018 07:22
@OwlyCode
Copy link
Contributor Author

@mcg-web done !

Copy link
Contributor

@mcg-web mcg-web left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @OwlyCode!

@mcg-web mcg-web merged commit ec579a9 into overblog:0.10 Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants