Skip to content

Fix parsing of default value #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 10, 2018
Merged

Fix parsing of default value #400

merged 2 commits into from
Oct 10, 2018

Conversation

enumag
Copy link
Contributor

@enumag enumag commented Oct 9, 2018

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Documented? no
Fixed tickets #399
License MIT

@enumag
Copy link
Contributor Author

enumag commented Oct 9, 2018 •
edited
Loading

@mcg-web The build is failing because the AST::valueFromASTUntyped() is only available in webonyx/graphql-php 0.12. How do you want me to proceed here? Simply fix the switch in this branch and send second PR for master branch (which requires v0.12) to use that method?

@mcg-web
Copy link
Contributor

mcg-web commented Oct 9, 2018 •
edited
Loading

Lets proceed so, fixing directly the switch , we will fix it on master later using native method. 👍

@mcg-web
Copy link
Contributor

mcg-web commented Oct 10, 2018

Thank you @enumag 👍

@mcg-web mcg-web merged commit 2fa7a9e into overblog:0.11 Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcg-web mcg-web mcg-web approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enumag @mcg-web