Handle @IsPublic & @Access on @Provider to define default values #507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Vincz
commented
Jun 25, 2019
Vincz
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Documented? | yes |
| Fixed tickets | #506 |
| License | MIT |
|
Thank @Vincz, we could make this one pass in 0.12 since it security scope. What do you think of this? |
mcg-web
approved these changes
Jun 25, 2019
Sorry my friend, not sure what you mean. Do you want to merge it in the 0.12, or skip it for the 0.12 and wait for the 0.13 ? |
|
it's ok for you to submit this for 0.12 branch? |
|
Ho ok, sorry. Yes, yes, no problem for 0.12 :) |
|
Not a big deal we will keep it in 0.13, thank you @Vincz 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.