Skip to content

Removed silent try catching on access resolver #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2016
Merged

Removed silent try catching on access resolver #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ overblog_graphql_endpoint:
resource: "@OverblogGraphQLBundle/Resources/config/routing/graphql.yml"
```

**c)** Enable GraphiQL in dev mode (required twig)
**d)** Enable GraphiQL in dev mode (required twig)

```yaml
# in app/config/routing_dev.yml
Expand Down Expand Up @@ -865,8 +865,8 @@ Expression | Description | Scope
---------- | ----------- | --------
**container** | DI container | global
**request** | Refers to the current request. | Request
**token** | Refers to the token which is currently in the security token storage. | Token
**user** | Refers to the user which is currently in the security token storage. | Valid Token
**token** | Refers to the token which is currently in the security token storage. Token can be null. | Token
**user** | Refers to the user which is currently in the security token storage. User can be null. | Valid Token
**object** | Refers to the value of the field for which access is being requested. For array `object` will be each item of the array. For Relay connection `object` will be the node of each connection edges. | only available for `config.fields.*.access` with query operation or mutation payload type.
**value** | Resolver value | only available in resolve context
**args** | Resolver args array | only available in resolve context
Expand Down
7 changes: 1 addition & 6 deletions Resolver/AccessResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,12 +70,7 @@ function (Edge $edge) use ($accessChecker, $resolveArgs) {
private function hasAccess(callable $accessChecker, $object, array $resolveArgs = [])
{
$resolveArgs[] = $object;

try {
$access = (bool) call_user_func_array($accessChecker, $resolveArgs);
} catch (\Exception $e) {
$access = false;
}
$access = (bool) call_user_func_array($accessChecker, $resolveArgs);

return $access;
}
Expand Down
21 changes: 0 additions & 21 deletions Tests/Functional/Security/AccessTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,27 +156,6 @@ public function testUserAccessToUserFriends()
$this->assertResponse($this->userFriendsQuery, $expected, static::USER_ADMIN);
}

public function testUserAccessToUserIsEnabledWithExpressionLanguageEvaluationFailed()
{
$expected = [
'data' => [
'user' => [
'isEnabled' => null,
],
],
'extensions' => [
'warnings' => [
[
'message' => 'Access denied to this field.',
'locations' => [['line' => 1, 'column' => 24]],
],
],
],
];

$this->assertResponse($this->userIsEnabledQuery, $expected, static::USER_ADMIN);
}

public function testMutationAllowedUser()
{
$result = 123;
Expand Down
1 change: 0 additions & 1 deletion Tests/Functional/app/config/access/mapping/access.types.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ User:
resolve: ['ROLE_USER']
isEnabled:
type: Boolean
access: "@=service('fake').fake()"
resolve: true
friends:
access: "@=object === 1"
Expand Down