Skip to content

Conversation

sukano
Copy link

@sukano sukano commented Aug 27, 2019

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Documented? no
Fixed tickets no
License MIT

Fix Paginator.auto() when $args['last'] === null (it try to backward and failed).

Copy link
Contributor

@mcg-web mcg-web left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this issue is cause by this line using isset instead of array_key_exists since array_key_exists return true for an existing key even the value is null.

Copy link
Contributor

@mcg-web mcg-web left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sukano 👍

@mcg-web mcg-web merged commit 1c3b61a into overblog:master Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants