fix(field-resolver): re-add support for isser methods

[Kocal]

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	yes/no
Tests pass?	yes
Documented?	yes
Fixed tickets	#...
License	MIT

I'm updating from 0.11 to 0.13 on our big app at work, and we have a lot of errors on fields which depend of isser methods.

Isser methods support has been removed in 0.13, because the Symfony PropertyAccessor has been removed too, due to performance issue for large schema.

However, I think it can be nice to re-add a basic support out-of-the-box for issers.

What do you think?
Thanks!

[mcg-web]

Thank you @Kocal

[ruudk]

Will it work when the field is called isEnabled and the method is called function isEnabled() : bool? By looking at the code, I expect it will try to fetch it as property but I could be wrong.

[mcg-web]

some PHP CS fix required

[mcg-web]

@ruudk yes because we test isser before public property.

[ruudk]

@mcg-web Maybe this explain it better: https://3v4l.org/tfb8l

[ruudk]

Maybe a fix could be to add another elseif like this:

} elseif (null !== $getter = self::guessObjectMethod($objectOrArray, $fieldName, '')) { // prefix is empty so it will try `isValid()`
    $value = $objectOrArray->$getter();
}

[mcg-web]

Maybe the best fix to this issue is to add an optional ResolverPropertyAccess that required PropertyAccess. So your both projects will be sure to work like be before 0.13. I want to keep the default as simple as possible, I don't want to rewrite PropertyAccess component here. Can this satisfy both of you @Kocal and @ruudk?

[ruudk]

Hmm, then I'd rather have this PR merged, and I will fix these "special" cases on my side.... feels like a missing feature to me but don't want to further complicate GraphQLBundle project with having to support 2 types of property access resolvers.

[Kocal]

Both options are fine for me

[mcg-web]

Ok, I'll merge this one! anyway you can use config to define your custom default field resolver

overblog_graphql:
    definitions:
         default_field_resolver: my_custom_service_id

[ruudk]

Thanks for merging. Is it too soon to ask for a tagged release 🙈 😂 ?

[mcg-web]

Maybe a fix could be to add another elseif like this:

} elseif (null !== $getter = self::guessObjectMethod($objectOrArray, $fieldName, '')) { // prefix is empty so it will try `isValid()`
    $value = $objectOrArray->$getter();
}

@ruudk I'm going also to (re-)introduce before release since it is also present on master.