Avoid creating services before compiler passes are all done #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ooflorent
previously requested changes
Nov 18, 2016
|
|
||
| if ($solution instanceof ContainerAwareInterface) { | ||
| $definition = $container->findDefinition($solutionID); | ||
| if (is_subclass_of($definition->getClass(), 'Symfony\Component\DependencyInjection\ContainerAwareInterface')) { |
There was a problem hiding this comment.
I don't like this. Using the ::class keywords would be better.
if (is_subclass_of($definition->getClass(), ContainerAwareInterface::class)) {
mcg-web
requested changes
Nov 18, 2016
| } | ||
| } | ||
|
|
||
| class FakeCompilerPass implements CompilerPassInterface |
There was a problem hiding this comment.
Create separate files for each class to respect psr4 please, thanks for the work :)
mcg-web
dismissed
ooflorent’s stale review
::class not compatible with php 5.4...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
$container->get()should not be called during compiler passes to avoid issues where a resolver service (for instance), implements ContainerAwareInterface and for which a service is not fully yet created.This fix uses
$container->findDefinition()instead and checks if the class (string) is a sub class of the interface.