Update relay

Command/GraphQLDumpSchemaCommand.php

@@ -57,7 +57,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
             ->execute($request, [], $schemaName)
             ->toArray();
 
-        $file = $input->getOption('file') ?: $container->getParameter('kernel.root_dir').sprintf('/../var/schema%s.json', $schemaName? '.'.$schemaName:'');
+        $file = $input->getOption('file') ?: $container->getParameter('kernel.root_dir').sprintf('/../var/schema%s.json', $schemaName ? '.'.$schemaName : '');
 
         $schema = json_encode($result['data']);
 

Error/ErrorHandler.php

@@ -14,8 +14,8 @@
 use GraphQL\Error;
 use GraphQL\Executor\ExecutionResult;
 use Psr\Log\LoggerInterface;
-use Psr\Log\NullLogger;
 use Psr\Log\LogLevel;
+use Psr\Log\NullLogger;
 
 class ErrorHandler
 {

README.md

@@ -891,6 +891,7 @@ Expression | Description | Scope
 **value** | Resolver value | only available in resolve context 
 **args** | Resolver args array | only available in resolve context 
 **info** | Resolver GraphQL\Type\Definition\ResolveInfo Object | only available in resolve context
+**context** | context is defined by your application on the top level of query execution (useful for storing current user, environment details, etc) | only available in resolve context
 **childrenComplexity** | Selection field children complexity | only available in complexity context
 
 [For more details on expression syntax](http://symfony.com/doc/current/components/expression_language/syntax.html)

Relay/Connection/Output/ConnectionBuilder.php

@@ -93,9 +93,17 @@ public static function connectionFromArraySlice($arraySlice, $args, array $meta)
         $endOffset = min($sliceEnd, $beforeOffset, $arrayLength);
 
         if (is_numeric($first)) {
+            if ($first < 0) {
+                throw new \InvalidArgumentException('Argument "first" must be a non-negative integer');
+            }
             $endOffset = min($endOffset, $startOffset + $first);
         }
+
         if (is_numeric($last)) {
+            if ($last < 0) {
+                throw new \InvalidArgumentException('Argument "last" must be a non-negative integer');
+            }
+
             $startOffset = max($startOffset, $endOffset - $last);
         }
 

Relay/Connection/Paginator.php

@@ -1,5 +1,14 @@
 <?php
 
+/*
+ * This file is part of the OverblogGraphQLBundle package.
+ *
+ * (c) Overblog <http://github.com/overblog/>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
 namespace Overblog\GraphQLBundle\Relay\Connection;
 
 use Overblog\GraphQLBundle\Definition\Argument;

Relay/Mutation/InputDefinition.php

@@ -30,7 +30,7 @@ public function toMappingDefinition(array $config)
                     'fields' => array_merge(
                         $inputFields,
                         [
-                            'clientMutationId' => ['type' => 'String!'],
+                            'clientMutationId' => ['type' => 'String'],
                         ]
                     ),
                 ],

Relay/Mutation/PayloadDefinition.php

@@ -29,7 +29,7 @@ public function toMappingDefinition(array $config)
                     'fields' => array_merge(
                         $outputFields,
                         [
-                            'clientMutationId' => ['type' => 'String!'],
+                            'clientMutationId' => ['type' => 'String'],
                         ]
                     ),
                 ],

Request/Executor.php

@@ -57,8 +57,7 @@ public function __construct(
         ErrorHandler $errorHandler = null,
         $hasDebugInfo = false,
         callable $executor = null
-    )
-    {
+    ) {
         $this->dispatcher = $dispatcher;
         $this->throwException = (bool) $throwException;
         $this->errorHandler = $errorHandler;
@@ -67,7 +66,6 @@ public function __construct(
         if (null === $this->executor) {
             $this->executor = self::DEFAULT_EXECUTOR;
         }
-
     }
 
     public function setExecutor(callable $executor)
@@ -152,7 +150,7 @@ public function execute(array $data, array $context = [], $schemaName = null)
             isset($data[ParserInterface::PARAM_OPERATION_NAME]) ? $data[ParserInterface::PARAM_OPERATION_NAME] : null
         );
 
-        if (!is_object($executionResult)  || !$executionResult instanceof ExecutionResult) {
+        if (!is_object($executionResult) || !$executionResult instanceof ExecutionResult) {
             throw new \RuntimeException(sprintf('Execution result should be an object instantiating "%s".', 'GraphQL\\Executor\\ExecutionResult'));
         }
 

Tests/DependencyInjection/Compiler/FakeCompilerPass.php

@@ -1,14 +1,22 @@
 <?php
 
+/*
+ * This file is part of the OverblogGraphQLBundle package.
+ *
+ * (c) Overblog <http://github.com/overblog/>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
 namespace Overblog\GraphQLBundle\Tests\DependencyInjection\Compiler;
 
 use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Reference;
 
 /**
- * Class FakeCompilerPass
- * @package DependencyInjection\Compiler
+ * Class FakeCompilerPass.
  */
 class FakeCompilerPass implements CompilerPassInterface
 {

Tests/DependencyInjection/Compiler/FakeInjectedService.php

@@ -1,9 +1,18 @@
 <?php
 
+/*
+ * This file is part of the OverblogGraphQLBundle package.
+ *
+ * (c) Overblog <http://github.com/overblog/>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
 namespace Overblog\GraphQLBundle\Tests\DependencyInjection\Compiler;
 
 /**
- * Class FakeInjectedService
+ * Class FakeInjectedService.
  */
 class FakeInjectedService
 {

Tests/DependencyInjection/Compiler/ResolverTaggedServiceMappingPassTest.php

@@ -1,14 +1,22 @@
 <?php
 
+/*
+ * This file is part of the OverblogGraphQLBundle package.
+ *
+ * (c) Overblog <http://github.com/overblog/>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
 namespace Overblog\GraphQLBundle\Tests\DependencyInjection\Compiler;
 
 use Overblog\GraphQLBundle\DependencyInjection\Compiler\ResolverTaggedServiceMappingPass;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Definition;
 
 /**
- * Class ResolverTaggedServiceMappingPassTest
- * @package DependencyInjection
+ * Class ResolverTaggedServiceMappingPassTest.
  */
 class ResolverTaggedServiceMappingPassTest extends \PHPUnit_Framework_TestCase
 {
@@ -27,13 +35,13 @@ public function setUp()
 
         $container->register(
             'overblog_graphql.resolver_resolver',
-            "Overblog\\GraphQLBundle\\Resolver\\ResolverResolver"
+            'Overblog\\GraphQLBundle\\Resolver\\ResolverResolver'
         );
 
         $testResolver = new Definition('Overblog\GraphQLBundle\Tests\DependencyInjection\Compiler\ResolverTestService');
         $testResolver
-            ->addTag( 'overblog_graphql.resolver', [
-                'alias' => 'test_resolver', 'method' => 'doSomethingWithContainer'
+            ->addTag('overblog_graphql.resolver', [
+                'alias' => 'test_resolver', 'method' => 'doSomethingWithContainer',
             ]);
 
         $container->setDefinition('test_resolver', $testResolver);
@@ -43,9 +51,9 @@ public function setUp()
 
     private function addCompilerPassesAndCompile()
     {
-            $this->container->addCompilerPass(new ResolverTaggedServiceMappingPass());
-            $this->container->addCompilerPass(new FakeCompilerPass());
-            $this->container->compile();
+        $this->container->addCompilerPass(new ResolverTaggedServiceMappingPass());
+        $this->container->addCompilerPass(new FakeCompilerPass());
+        $this->container->compile();
     }
 
     public function testCompilationWorksPassConfigDirective()

Tests/DependencyInjection/Compiler/ResolverTestService.php

@@ -1,13 +1,21 @@
 <?php
 
+/*
+ * This file is part of the OverblogGraphQLBundle package.
+ *
+ * (c) Overblog <http://github.com/overblog/>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
 namespace DependencyInjection\Compiler;
 
 use Symfony\Component\DependencyInjection\ContainerAwareInterface;
 use Symfony\Component\DependencyInjection\ContainerAwareTrait;
 
 /**
- * Class ResolverTestService
- * @package DependencyInjection\Compiler
+ * Class ResolverTestService.
  */
 class ResolverTestService implements ContainerAwareInterface
 {

Tests/Functional/Controller/GraphControllerTest.php

@@ -106,7 +106,6 @@ public function testEndpointWithEmptyJsonBodyQuery()
         $client->getResponse()->getContent();
     }
 
-
     /**
      * @expectedException \Symfony\Component\HttpKernel\Exception\BadRequestHttpException
      * @expectedExceptionMessage POST body sent invalid JSON

Tests/Functional/Relay/Mutation/MutationTest.php

@@ -98,10 +98,6 @@ public function testContainsCorrectInput()
       type {
         name
         kind
-        ofType {
-          name
-          kind
-        }
       }
     }
   }
@@ -115,12 +111,8 @@ public function testContainsCorrectInput()
                     [
                         'name' => 'clientMutationId',
                         'type' => [
-                            'name' => null,
-                            'kind' => 'NON_NULL',
-                            'ofType' => [
-                                'name' => 'String',
-                                'kind' => 'SCALAR',
-                            ],
+                            'name' => 'String',
+                            'kind' => 'SCALAR',
                         ],
                     ],
                 ],
@@ -142,10 +134,6 @@ public function testContainsCorrectPayload()
       type {
         name
         kind
-        ofType {
-          name
-          kind
-        }
       }
     }
   }
@@ -162,18 +150,13 @@ public function testContainsCorrectPayload()
                         'type' => [
                             'name' => 'Int',
                             'kind' => 'SCALAR',
-                            'ofType' => null,
                         ],
                     ],
                     [
                         'name' => 'clientMutationId',
                         'type' => [
-                            'name' => null,
-                            'kind' => 'NON_NULL',
-                            'ofType' => [
-                                'name' => 'String',
-                                'kind' => 'SCALAR',
-                            ],
+                            'name' => 'String',
+                            'kind' => 'SCALAR',
                         ],
                     ],
 

Tests/Relay/Connection/Output/ConnectionBuilderTest.php

@@ -178,6 +178,30 @@ public function testRespectsLastAndAfterAndBeforeExactlyRight()
         $this->assertEquals($expected, $actual);
     }
 
+    /**
+     * @expectedException \InvalidArgumentException
+     * @expectedExceptionMessage Argument "first" must be a non-negative integer
+     */
+    public function testThrowsAnErrorIfFirstLessThan0()
+    {
+        ConnectionBuilder::connectionFromArray(
+            $this->letters,
+            ['first' => -1]
+        );
+    }
+
+    /**
+     * @expectedException \InvalidArgumentException
+     * @expectedExceptionMessage Argument "last" must be a non-negative integer
+     */
+    public function testThrowsAnErrorIfLastLessThan0()
+    {
+        ConnectionBuilder::connectionFromArray(
+            $this->letters,
+            ['last' => -1]
+        );
+    }
+
     public function testReturnsNoElementsIfFirstIs0()
     {
         $actual = ConnectionBuilder::connectionFromArray(

Tests/Relay/Connection/PaginatorTest.php

@@ -1,5 +1,14 @@
 <?php
 
+/*
+ * This file is part of the OverblogGraphQLBundle package.
+ *
+ * (c) Overblog <http://github.com/overblog/>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
 namespace Overblog\GraphQLBundle\Tests\Relay\Connection;
 
 use Overblog\GraphQLBundle\Definition\Argument;
@@ -28,7 +37,7 @@ public function testForwardAfter()
             return array_fill(0, 6, 'item');
         });
 
-        $this->assertCount(5, $paginator->forward(new Argument(['first' => 5, 'after' => base64_encode('arrayconnection:5') ]))->edges);
+        $this->assertCount(5, $paginator->forward(new Argument(['first' => 5, 'after' => base64_encode('arrayconnection:5')]))->edges);
     }
 
     public function testBackward()
@@ -88,6 +97,7 @@ public function testAuto()
         $countCalled = false;
         $result = $paginator->auto(new Argument(['last' => 5]), function () use (&$countCalled) {
             $countCalled = true;
+
             return 10;
         });
 

Tests/Request/ExecutorTest.php

@@ -46,7 +46,9 @@ public function setUp()
      */
     public function testInvalidExecutorReturnNotObject()
     {
-        $this->executor->setExecutor(function() { return false; });
+        $this->executor->setExecutor(function () {
+            return false;
+        });
         $this->executor->execute($this->request);
     }
 
@@ -56,7 +58,9 @@ public function testInvalidExecutorReturnNotObject()
      */
     public function testInvalidExecutorReturnInvalidObject()
     {
-        $this->executor->setExecutor(function() { return new \stdClass(); });
+        $this->executor->setExecutor(function () {
+            return new \stdClass();
+        });
         $this->executor->execute($this->request);
     }