Skip to content

Conversation

alafon
Copy link
Contributor

@alafon alafon commented Dec 20, 2016

Make it possible to pass arguments for the callable used in the auto and backward function of the Paginator.

@mcg-web
Copy link
Contributor

mcg-web commented Dec 20, 2016

hi @alafon , with this change, is the documentation up to date?

@alafon alafon force-pushed the paginator-backward-callback-arguments branch from e807cb8 to a1b0759 Compare December 20, 2016 12:10
@alafon
Copy link
Contributor Author

alafon commented Dec 20, 2016

@mcg-web actually there was no documentation about the auto() or backward() methods so no update is needed. But I'll improve it anyway.

@mcg-web
Copy link
Contributor

mcg-web commented Dec 20, 2016

ok nice, thank you 👍

@mcg-web
Copy link
Contributor

mcg-web commented Dec 20, 2016

tips: use cli php-cs-fixer fix . or add the header to fix ci build...

@alafon alafon force-pushed the paginator-backward-callback-arguments branch from a1b0759 to 6febcec Compare December 20, 2016 12:29
@alafon
Copy link
Contributor Author

alafon commented Dec 20, 2016

I did but like this vendor/bin/php-cs-fixer fix --dry-run --diff Tests/Relay/Connection/...
Didn't know that php-cs-fixer does not use the configuration file when using a target... now I know.

@alafon
Copy link
Contributor Author

alafon commented Dec 20, 2016

Added a small piece of doc with a "silly" example, but it does the job :)

Copy link
Contributor

@mcg-web mcg-web left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcg-web
Copy link
Contributor

mcg-web commented Dec 20, 2016

thank you @alafon for contribution ;)

@mcg-web mcg-web merged commit d263c73 into overblog:master Dec 20, 2016
@alafon alafon deleted the paginator-backward-callback-arguments branch December 22, 2016 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants