Skip to content

Builders #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 10, 2017
Merged

Builders #97

merged 3 commits into from
Feb 10, 2017

Conversation

mcg-web
Copy link
Contributor

@mcg-web mcg-web commented Jan 2, 2017 •
edited
Loading

Q A
Bug fix? No
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Documented? yes
License MIT
  • Allow Args builder config
  • Better field builder documentation

@mcg-web mcg-web added the wip label Jan 3, 2017
Nyalab
Nyalab reviewed Jan 12, 2017
View reviewed changes
Resources/doc/definitions/builders/args.md
#...
builders:
args:
-
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this normal?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it means that we need a list of alias/class values

@mcg-web mcg-web removed the wip label Feb 9, 2017
@mcg-web mcg-web requested a review from barduck007 February 10, 2017 07:46
@mcg-web mcg-web merged commit ecb2854 into overblog:master Feb 10, 2017
@mcg-web mcg-web deleted the builders branch February 10, 2017 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barduck007 barduck007 barduck007 approved these changes

+1 more reviewer

@Nyalab Nyalab Nyalab left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcg-web @Nyalab @barduck007