Skip to content

Conversation

thedustin
Copy link

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Documented? yes
Fixed tickets #984
License MIT

Added back the isTypeOf configuration in the TypeBuilder.

Please release soon as a new bugfix version.

Copy link
Contributor

@mcg-web mcg-web left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Can you please apply changes and submit this for 0.14 branch please ?

@thedustin thedustin changed the base branch from master to 0.14 February 14, 2022 09:07
@thedustin thedustin changed the base branch from 0.14 to master February 14, 2022 09:08
@thedustin thedustin changed the base branch from master to 0.14 February 14, 2022 10:28
@thedustin thedustin requested a review from mcg-web February 15, 2022 08:35
@thedustin
Copy link
Author

The failing test fails for me even for a clean 0.14 branch, so my pull request doesn't broke it.

@mcg-web mcg-web closed this Feb 15, 2022
@mcg-web mcg-web reopened this Feb 15, 2022
@mcg-web
Copy link
Contributor

mcg-web commented Feb 18, 2022

Thank you @thedustin !

@mcg-web mcg-web merged commit d914619 into overblog:0.14 Feb 18, 2022
@thedustin thedustin deleted the fix-missing-is-type-of branch February 18, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants