Fix extra spaces inserted into multi-line strings #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcg-web
requested changes
Feb 8, 2017
.gitignore
Outdated
| @@ -1,3 +1,4 @@ | |||
| .idea/ | |||
There was a problem hiding this comment.
This should be done in global gitignore file.
| case is_object($var): | ||
| return $default; | ||
|
|
||
| case is_string($var): |
There was a problem hiding this comment.
Can you add a test for this case please?
There was a problem hiding this comment.
I updated the Star Wars schema to have a description which would trigger this bug - or would you prefer a more involved test?
added 2 commits
February 9, 2017 14:07
This prevents bugs that occur when extra spaces are inserted into a multi-line string in AbstractClassGenerator::prefixCodeWithSpaces call.
…a spaces inserted bug.
ir-regular
force-pushed
the
remove-extra-spaces-description
branch
from
6a310ca to
a2df905
Compare
mcg-web
approved these changes
Feb 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change
Multi-line strings get split by
AbstractClassGenerator::prefixCodeWithSpaces()into separate lines and then each of these lines gets prefixed with spaces. This has the effect of inserting extra spaces into multi-line strings.The specific area where this shows up is GraphQL schema element descriptions, which can be optionally formatted using Markdown syntax, and multiple spaces cause change of formatting.
Fix description
For multi-line strings, instead of using a raw
var_exportresult, split the string into separate lines and concatenate newline-containing strings separately.