Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The theme *.scss files are all ignored #24

Closed
regisb opened this issue May 30, 2022 · 1 comment · Fixed by #25
Closed

The theme *.scss files are all ignored #24

regisb opened this issue May 30, 2022 · 1 comment · Fixed by #25
Labels
bug Something isn't working

Comments

@regisb
Copy link
Contributor

regisb commented May 30, 2022

All scss files that ship with this theme (including "_extras.scss") are not rendered in the Tutor project environment. That's because they are located in a "partials" folder which is explicitly ignored by Tutor: https://github.com/overhangio/tutor/blob/669f8363283c5351ff39007e06df42dd1c48b2c7/tutor/env.py#L75

This issue was detected in this conversation: #23 (comment)

The proper solution would probably be to move the files from the "partials" folder and put them directly in the "indigo" directory. I need to check whether this would be working.
@regisb regisb added the bug Something isn't working label May 30, 2022
@regisb regisb mentioned this issue May 30, 2022
Merged
@insad
Copy link
Contributor

insad commented May 30, 2022

I suppose in my installation this is still working correctly, because I'm not using the tutor-indigo plugin version, but still the old version (using tutor config render).
Have also some more suggestions for the indigo theme, like using a secondary color, and making the height of the logo adjustable, but will leave these until you can sort this problem out.

regisb added a commit to overhangio/tutor that referenced this issue May 30, 2022
@regisb
feat: render files in ignored directories
e1de325 
When rendering theme files in a plugin, the *.scss files are stored in a
"partials" subdirectory, which was ignored by the environment rendering logic.
To render these files, we move the path ignoring logic to a filter, which is a
list of regular expressions. Values in this filter can be overridden by another
filter.

See the corresponding issue in the indigo theme plugin:
overhangio/tutor-indigo#24
regisb added a commit to overhangio/tutor that referenced this issue May 30, 2022
@regisb
feat: render files in ignored directories
38e12df 
When rendering theme files in a plugin, the *.scss files are stored in a
"partials" subdirectory, which was ignored by the environment rendering logic.
To render these files, we move the path ignoring logic to a filter, which is a
list of regular expressions. Values in this filter can be overridden by another
filter.

See the corresponding issue in the indigo theme plugin:
overhangio/tutor-indigo#24
@regisb regisb mentioned this issue May 30, 2022
Merged
regisb added a commit to overhangio/tutor that referenced this issue May 30, 2022
@regisb
feat: render files in ignored directories
31e4115 
When rendering theme files in a plugin, the *.scss files are stored in a
"partials" subdirectory, which was ignored by the environment rendering logic.
To render these files, we move the path ignoring logic to a filter, which is a
list of regular expressions. Values in this filter can be overridden by another
filter.

See the corresponding issue in the indigo theme plugin:
overhangio/tutor-indigo#24
regisb added a commit that referenced this issue May 30, 2022
@regisb
fix: actually render scss files in tutor env
b7ed342 
*.scss files were not rendered at all in the tutor environment because they are
stored in a "partials" subdirectory.

Here, we make use of the new pattern include/ignore filter to force the
rendering of the indigo theme directory.

Close #24.
regisb added a commit that referenced this issue May 30, 2022
@regisb
fix: actually render scss files in tutor env
763e965 
*.scss files were not rendered at all in the tutor environment because they are
stored in a "partials" subdirectory.

Here, we make use of the new pattern include/ignore filter to force the
rendering of the indigo theme directory.

Close #24.
@regisb regisb mentioned this issue May 30, 2022
Merged
regisb added a commit to overhangio/tutor that referenced this issue Jun 3, 2022
@regisb
feat: render files in ignored directories
82f2a44 
When rendering theme files in a plugin, the *.scss files are stored in a
"partials" subdirectory, which was ignored by the environment rendering logic.
To render these files, we move the path ignoring logic to a filter, which is a
list of regular expressions. Values in this filter can be overridden by another
filter.

See the corresponding issue in the indigo theme plugin:
overhangio/tutor-indigo#24
@regisb regisb closed this as completed in #25 Jun 3, 2022
regisb added a commit that referenced this issue Jun 3, 2022
@regisb
fix: actually render scss files in tutor env
7eeda48 
*.scss files were not rendered at all in the tutor environment because they are
stored in a "partials" subdirectory.

Here, we make use of the new pattern include/ignore filter to force the
rendering of the indigo theme directory.

Close #24.
@Talha-Rizwan Talha-Rizwan mentioned this issue Feb 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: actually render scss files in tutor env overhangio/tutor-indigo
2 participants
@regisb @insad