No module named 'third_party_auth' issue solved #604
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regisb
reviewed
Mar 10, 2022
| @@ -53,7 +53,7 @@ Enable SAML authentication | |||
|
|
|||
| openedx-lms-common-settings: | | |||
| # saml special settings | |||
| AUTHENTICATION_BACKENDS += ["third_party_auth.saml.SAMLAuthBackend", "django.contrib.auth.backends.ModelBackend"] | |||
| THIRD_PARTY_AUTH_BACKENDS = ["third_party_auth.saml.SAMLAuthBackend"] | |||
There was a problem hiding this comment.
Are you quite sure that this is the right fix? Looking at the source code, the THIRD_PARTY_AUTH_BACKENDS setting is not read at all. I believe that the import error is caused by the fact that we should now specify the full import path: common.djangoapps.third_party_auth.saml.SAMLAuthBackend.
Can you please test again your plugin and my proposed change, see which one works?
regisb
added a commit
that referenced
this pull request
Mar 17, 2022
|
Closed in favor of 2cf4e6d |
regisb
added a commit
that referenced
this pull request
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the fix for #601
I tested
THIRD_PARTY_AUTH_BACKENDS = ["third_party_auth.saml.SAMLAuthBackend"]and it's working. yay