Skip to content
This repository was archived by the owner on Aug 7, 2020. It is now read-only.

Conversation

Jisay
Copy link
Contributor

@Jisay Jisay commented Aug 23, 2018

Add to the component the enableTime option to display a time picker if needed.
See enableTime option of flatpickr for more information: https://flatpickr.js.org/options/

Copy link
Contributor

@antleblanc antleblanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you could update the README.md (API table) to reflect your change, right?

Copy link
Contributor

@AxelPeter AxelPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to commit the build files. Those are generated with each release.
Could you remove them ?

If needed in another project, prefer using another branch (eg. build/enableTime)

@AxelPeter
Copy link
Contributor

Since it's a feature, could you target the develop branch ?

@Jisay Jisay changed the base branch from master to develop September 4, 2018 08:40
@AxelPeter AxelPeter merged commit 6e48743 into develop Sep 4, 2018
@AxelPeter AxelPeter deleted the feat/enableTime branch September 4, 2018 08:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

6 participants