This repository was archived by the owner on Aug 7, 2020. It is now read-only.
feat(oui-datagrid): add a way to customize empty placeholder #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euhmeuh
requested review from
AxelPeter,
FredericEspiau and
JeremyDec
as code owners
FredericEspiau
approved these changes
Aug 31, 2018
FredericEspiau
approved these changes
Aug 31, 2018
FredericEspiau
approved these changes
Aug 31, 2018
AxelPeter
suggested changes
Sep 3, 2018
packages/oui-datagrid/README.md
Outdated
| | `rows` | array | <? | yes | n/a | n/a | rows to show | ||
| | `rows-loader` | function | &? | yes | n/a | n/a | gets all rows (returns a promise with all rows) | ||
| | `row-loader` | function | &? | yes | n/a | n/a | gets row details (returns a promise with details) | ||
| | `empty-text` | string | @? | no | n/a | n/a | custom placeholder text when there is no data |
There was a problem hiding this comment.
I think we should go with empty-placeholder, since we use emptyPlaceholder in the translations provider
JeremyDec
approved these changes
Sep 3, 2018
AxelPeter
reviewed
Sep 3, 2018
| > | ||
| <span ng-if="!$ctrl.loading && !$ctrl.firstLoading" | ||
| ng-bind="$ctrl.config.translations.emptyPlaceholder"></span> | ||
| ng-bind="$ctrl.emptyText || $ctrl.config.translations.emptyPlaceholder"></span> |
There was a problem hiding this comment.
This should be one-time binded.
Don't forget to update the API table too :)
euhmeuh
force-pushed
the
feat/empty-text-datagrid
branch
from
dee0b7f to
b9ffb59
Compare
AxelPeter
approved these changes
Sep 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a way to specify the text when there's no elements in a datagrid.