This repository was archived by the owner on Aug 7, 2020. It is now read-only.
feat(oui-message): add dismissable attribute #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AxelPeter
requested review from
FredericEspiau,
JeremyDec and
euhmeuh
as code owners
euhmeuh
approved these changes
Sep 7, 2018
JeremyDec
approved these changes
Sep 7, 2018
FredericEspiau
approved these changes
Sep 7, 2018
|
|
||
| $onInit () { | ||
| // Guidelines default value for dismissable attribute | ||
| addDefaultParameter(this, "dismissable", this.type === "info" || this.type === "success"); |
There was a problem hiding this comment.
Could have an array of types that are dissimisable by default
There was a problem hiding this comment.
What's your proposition ?
There was a problem hiding this comment.
message.constants.js
angular
.module("moduleName")
.constant("MESSAGE_CONSTANTS", () => {
TYPES: {
info: {
dismissableByDefault: true
},
...
}
})message.controller.js
addDefaultParameter(this, "dismissable", this.MESSAGE_CONSTANTS.TYPES[this.type].isDismissableByDefaultThe constants could contain more data about types and would make it easier to add new types, if the need ever rise.
I would understand if you considered it over-engineering 😄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://angular_feature_closable_message.ui-kit.ovh/#!/oui-angular/message