northd/automake.mk: Extract deps from .la files for cargo. #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ryzhyk LGTM. Acked-by: Numan Siddique numans@ovn.org I guess you would merge this patch. |
ovn-northd-ddlog depends on `libopenvswitch.a` and `libovn.a`. Therefore, when we compile a standalone executable (enabled by the `--enable-ddlog-northd-cli` switch to `configure`), it must be linked against these libraries *and* their dependencies. The latter is tricky, since `cargo` (the Rust build system) does not understand libtool files, so we don't have an easy way to pull in dependencies automatically. Until now, we dealt with this by manually listing dependencies in the `cargo` command line. This no longer works as OVS now has at least one configurable dependency, the `libunwind.a` library, that is enabled by the OVS configuration script. This results is link errors with the latest version of OVS. The only solution I could come up with is to extract dependencies from `libopenvswitch.a` and `libovn.a` using `grep` and pass them to cargo. Signed-off-by: Leonid Ryzhyk <ryzhyk@ovn.org>
LorenzoBianconi
added a commit
to LorenzoBianconi/ovn
that referenced
this pull request
Apr 15, 2022
Avoid the following crash in ovn-trace due to a reject action infinite
loop:
AddressSanitizer:DEADLYSIGNAL
==569410==ERROR: AddressSanitizer: stack-overflow on address 0x7ffc0a991bc4 (pc 0x000000415081 bp 0x7ffc0a993fa0 sp 0x7ffc0a991b30 T0)
#0 0x415081 in trace_actions utilities/ovn-trace.c:2617
ovn-org#1 0x41d878 in trace_actions utilities/ovn-trace.c:2622
ovn-org#2 0x41d878 in trace__ utilities/ovn-trace.c:3007
ovn-org#3 0x41e3a8 in execute_output utilities/ovn-trace.c:1700
ovn-org#4 0x416fcf in trace_actions utilities/ovn-trace.c:2640
ovn-org#5 0x41d878 in trace_actions utilities/ovn-trace.c:2622
ovn-org#6 0x41d878 in trace__ utilities/ovn-trace.c:3007
ovn-org#7 0x41788d in execute_next utilities/ovn-trace.c:2307
ovn-org#8 0x41788d in trace_actions utilities/ovn-trace.c:2644
ovn-org#9 0x41a7c0 in trace_actions utilities/ovn-trace.c:2622
ovn-org#10 0x41a7c0 in execute_sctp4_abort utilities/ovn-trace.c:1985
ovn-org#11 0x419671 in execute_reject utilities/ovn-trace.c:2049
ovn-org#12 0x419671 in trace_actions utilities/ovn-trace.c:2860
ovn-org#13 0x41d878 in trace_actions utilities/ovn-trace.c:2622
ovn-org#14 0x41d878 in trace__ utilities/ovn-trace.c:3007
ovn-org#15 0x41e3a8 in execute_output utilities/ovn-trace.c:1700
ovn-org#16 0x416fcf in trace_actions utilities/ovn-trace.c:2640
ovn-org#17 0x41d878 in trace_actions utilities/ovn-trace.c:2622
ovn-org#18 0x41d878 in trace__ utilities/ovn-trace.c:3007
ovn-org#19 0x41788d in execute_next utilities/ovn-trace.c:2307
ovn-org#20 0x41788d in trace_actions utilities/ovn-trace.c:2644
ovn-org#21 0x41a7c0 in trace_actions utilities/ovn-trace.c:2622
ovn-org#22 0x41a7c0 in execute_sctp4_abort utilities/ovn-trace.c:1985
ovn-org#23 0x419671 in execute_reject utilities/ovn-trace.c:2049
ovn-org#24 0x419671 in trace_actions utilities/ovn-trace.c:2860
ovn-org#25 0x41d878 in trace_actions utilities/ovn-trace.c:2622
ovn-org#26 0x41d878 in trace__ utilities/ovn-trace.c:3007
ovn-org#27 0x41e3a8 in execute_output utilities/ovn-trace.c:1700
ovn-org#28 0x416fcf in trace_actions utilities/ovn-trace.c:2640
ovn-org#29 0x41d878 in trace_actions utilities/ovn-trace.c:2622
ovn-org#30 0x41d878 in trace__ utilities/ovn-trace.c:3007
ovn-org#31 0x41788d in execute_next utilities/ovn-trace.c:2307
ovn-org#32 0x41788d in trace_actions utilities/ovn-trace.c:2644
ovn-org#33 0x41a7c0 in trace_actions utilities/ovn-trace.c:2622
ovn-org#34 0x41a7c0 in execute_sctp4_abort utilities/ovn-trace.c:1985
ovn-org#35 0x419671 in execute_reject utilities/ovn-trace.c:2049
ovn-org#36 0x419671 in trace_actions utilities/ovn-trace.c:2860
ovn-org#37 0x41d878 in trace_actions utilities/ovn-trace.c:2622
ovn-org#38 0x41d878 in trace__ utilities/ovn-trace.c:3007
ovn-org#39 0x41e3a8 in execute_output utilities/ovn-trace.c:1700
ovn-org#40 0x416fcf in trace_actions utilities/ovn-trace.c:2640
ovn-org#41 0x41d878 in trace_actions utilities/ovn-trace.c:2622
ovn-org#42 0x41d878 in trace__ utilities/ovn-trace.c:3007
ovn-org#43 0x41788d in execute_next utilities/ovn-trace.c:2307
....
The issue can be triggered with the following reproducer:
$ovn-nbctl ls-add sw
$ovn-nbctl lsp-add sw p1
$ovn-nbctl lsp-set-addresses p1 "00:00:00:00:00:02 192.168.0.2"
$ovn-nbctl lsp-add sw p2
$ovn-nbctl lsp-set-addresses p2 "00:00:00:00:00:03 192.168.0.3"
$ovn-nbctl pg-add pg1 p1 p2
$ovn-nbctl acl-add pg1 to-lport 2003 "inport==@pg1 && ip4 && ip4.src == 192.168.0.0/16 && udp && udp.dst == 9000" allow
$ovn-nbctl acl-add pg1 to-lport 2001 "inport==@pg1" reject
$ovn-trace 'inport == "p2" && eth.src == 00:00:00:00:00:03 && eth.dst == 00:00:00:00:00:02 && ip.ttl==42 && ip4.src == 192.168.0.3'
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2074537
ovsrobot
pushed a commit
to ovsrobot/ovn
that referenced
this pull request
Apr 15, 2022
Avoid the following crash in ovn-trace due to a reject action infinite
loop:
AddressSanitizer:DEADLYSIGNAL
==569410==ERROR: AddressSanitizer: stack-overflow on address 0x7ffc0a991bc4 (pc 0x000000415081 bp 0x7ffc0a993fa0 sp 0x7ffc0a991b30 T0)
#0 0x415081 in trace_actions utilities/ovn-trace.c:2617
ovn-org#1 0x41d878 in trace_actions utilities/ovn-trace.c:2622
ovn-org#2 0x41d878 in trace__ utilities/ovn-trace.c:3007
ovn-org#3 0x41e3a8 in execute_output utilities/ovn-trace.c:1700
ovn-org#4 0x416fcf in trace_actions utilities/ovn-trace.c:2640
ovn-org#5 0x41d878 in trace_actions utilities/ovn-trace.c:2622
ovn-org#6 0x41d878 in trace__ utilities/ovn-trace.c:3007
ovn-org#7 0x41788d in execute_next utilities/ovn-trace.c:2307
ovn-org#8 0x41788d in trace_actions utilities/ovn-trace.c:2644
ovn-org#9 0x41a7c0 in trace_actions utilities/ovn-trace.c:2622
ovn-org#10 0x41a7c0 in execute_sctp4_abort utilities/ovn-trace.c:1985
ovn-org#11 0x419671 in execute_reject utilities/ovn-trace.c:2049
ovn-org#12 0x419671 in trace_actions utilities/ovn-trace.c:2860
ovn-org#13 0x41d878 in trace_actions utilities/ovn-trace.c:2622
ovn-org#14 0x41d878 in trace__ utilities/ovn-trace.c:3007
ovn-org#15 0x41e3a8 in execute_output utilities/ovn-trace.c:1700
ovn-org#16 0x416fcf in trace_actions utilities/ovn-trace.c:2640
ovn-org#17 0x41d878 in trace_actions utilities/ovn-trace.c:2622
ovn-org#18 0x41d878 in trace__ utilities/ovn-trace.c:3007
ovn-org#19 0x41788d in execute_next utilities/ovn-trace.c:2307
ovn-org#20 0x41788d in trace_actions utilities/ovn-trace.c:2644
ovn-org#21 0x41a7c0 in trace_actions utilities/ovn-trace.c:2622
ovn-org#22 0x41a7c0 in execute_sctp4_abort utilities/ovn-trace.c:1985
ovn-org#23 0x419671 in execute_reject utilities/ovn-trace.c:2049
ovn-org#24 0x419671 in trace_actions utilities/ovn-trace.c:2860
ovn-org#25 0x41d878 in trace_actions utilities/ovn-trace.c:2622
ovn-org#26 0x41d878 in trace__ utilities/ovn-trace.c:3007
ovn-org#27 0x41e3a8 in execute_output utilities/ovn-trace.c:1700
ovn-org#28 0x416fcf in trace_actions utilities/ovn-trace.c:2640
ovn-org#29 0x41d878 in trace_actions utilities/ovn-trace.c:2622
ovn-org#30 0x41d878 in trace__ utilities/ovn-trace.c:3007
ovn-org#31 0x41788d in execute_next utilities/ovn-trace.c:2307
ovn-org#32 0x41788d in trace_actions utilities/ovn-trace.c:2644
ovn-org#33 0x41a7c0 in trace_actions utilities/ovn-trace.c:2622
ovn-org#34 0x41a7c0 in execute_sctp4_abort utilities/ovn-trace.c:1985
ovn-org#35 0x419671 in execute_reject utilities/ovn-trace.c:2049
ovn-org#36 0x419671 in trace_actions utilities/ovn-trace.c:2860
ovn-org#37 0x41d878 in trace_actions utilities/ovn-trace.c:2622
ovn-org#38 0x41d878 in trace__ utilities/ovn-trace.c:3007
ovn-org#39 0x41e3a8 in execute_output utilities/ovn-trace.c:1700
ovn-org#40 0x416fcf in trace_actions utilities/ovn-trace.c:2640
ovn-org#41 0x41d878 in trace_actions utilities/ovn-trace.c:2622
ovn-org#42 0x41d878 in trace__ utilities/ovn-trace.c:3007
ovn-org#43 0x41788d in execute_next utilities/ovn-trace.c:2307
....
The issue can be triggered with the following reproducer:
$ovn-nbctl ls-add sw
$ovn-nbctl lsp-add sw p1
$ovn-nbctl lsp-set-addresses p1 "00:00:00:00:00:02 192.168.0.2"
$ovn-nbctl lsp-add sw p2
$ovn-nbctl lsp-set-addresses p2 "00:00:00:00:00:03 192.168.0.3"
$ovn-nbctl pg-add pg1 p1 p2
$ovn-nbctl acl-add pg1 to-lport 2003 "inport==@pg1 && ip4 && ip4.src == 192.168.0.0/16 && udp && udp.dst == 9000" allow
$ovn-nbctl acl-add pg1 to-lport 2001 "inport==@pg1" reject
$ovn-trace 'inport == "p2" && eth.src == 00:00:00:00:00:03 && eth.dst == 00:00:00:00:00:02 && ip.ttl==42 && ip4.src == 192.168.0.3'
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2074537
Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Signed-off-by: 0-day Robot <robot@bytheb.org>
putnopvut
pushed a commit
that referenced
this pull request
May 10, 2022
Avoid the following crash in ovn-trace due to a reject action infinite
loop:
AddressSanitizer:DEADLYSIGNAL
==569410==ERROR: AddressSanitizer: stack-overflow on address 0x7ffc0a991bc4 (pc 0x000000415081 bp 0x7ffc0a993fa0 sp 0x7ffc0a991b30 T0)
#0 0x415081 in trace_actions utilities/ovn-trace.c:2617
#1 0x41d878 in trace_actions utilities/ovn-trace.c:2622
#2 0x41d878 in trace__ utilities/ovn-trace.c:3007
#3 0x41e3a8 in execute_output utilities/ovn-trace.c:1700
#4 0x416fcf in trace_actions utilities/ovn-trace.c:2640
#5 0x41d878 in trace_actions utilities/ovn-trace.c:2622
#6 0x41d878 in trace__ utilities/ovn-trace.c:3007
#7 0x41788d in execute_next utilities/ovn-trace.c:2307
#8 0x41788d in trace_actions utilities/ovn-trace.c:2644
#9 0x41a7c0 in trace_actions utilities/ovn-trace.c:2622
#10 0x41a7c0 in execute_sctp4_abort utilities/ovn-trace.c:1985
#11 0x419671 in execute_reject utilities/ovn-trace.c:2049
#12 0x419671 in trace_actions utilities/ovn-trace.c:2860
#13 0x41d878 in trace_actions utilities/ovn-trace.c:2622
#14 0x41d878 in trace__ utilities/ovn-trace.c:3007
#15 0x41e3a8 in execute_output utilities/ovn-trace.c:1700
#16 0x416fcf in trace_actions utilities/ovn-trace.c:2640
#17 0x41d878 in trace_actions utilities/ovn-trace.c:2622
#18 0x41d878 in trace__ utilities/ovn-trace.c:3007
#19 0x41788d in execute_next utilities/ovn-trace.c:2307
#20 0x41788d in trace_actions utilities/ovn-trace.c:2644
#21 0x41a7c0 in trace_actions utilities/ovn-trace.c:2622
#22 0x41a7c0 in execute_sctp4_abort utilities/ovn-trace.c:1985
#23 0x419671 in execute_reject utilities/ovn-trace.c:2049
#24 0x419671 in trace_actions utilities/ovn-trace.c:2860
#25 0x41d878 in trace_actions utilities/ovn-trace.c:2622
#26 0x41d878 in trace__ utilities/ovn-trace.c:3007
#27 0x41e3a8 in execute_output utilities/ovn-trace.c:1700
#28 0x416fcf in trace_actions utilities/ovn-trace.c:2640
#29 0x41d878 in trace_actions utilities/ovn-trace.c:2622
#30 0x41d878 in trace__ utilities/ovn-trace.c:3007
#31 0x41788d in execute_next utilities/ovn-trace.c:2307
#32 0x41788d in trace_actions utilities/ovn-trace.c:2644
#33 0x41a7c0 in trace_actions utilities/ovn-trace.c:2622
#34 0x41a7c0 in execute_sctp4_abort utilities/ovn-trace.c:1985
#35 0x419671 in execute_reject utilities/ovn-trace.c:2049
#36 0x419671 in trace_actions utilities/ovn-trace.c:2860
#37 0x41d878 in trace_actions utilities/ovn-trace.c:2622
#38 0x41d878 in trace__ utilities/ovn-trace.c:3007
#39 0x41e3a8 in execute_output utilities/ovn-trace.c:1700
#40 0x416fcf in trace_actions utilities/ovn-trace.c:2640
#41 0x41d878 in trace_actions utilities/ovn-trace.c:2622
#42 0x41d878 in trace__ utilities/ovn-trace.c:3007
#43 0x41788d in execute_next utilities/ovn-trace.c:2307
....
The issue can be triggered with the following reproducer:
$ovn-nbctl ls-add sw
$ovn-nbctl lsp-add sw p1
$ovn-nbctl lsp-set-addresses p1 "00:00:00:00:00:02 192.168.0.2"
$ovn-nbctl lsp-add sw p2
$ovn-nbctl lsp-set-addresses p2 "00:00:00:00:00:03 192.168.0.3"
$ovn-nbctl pg-add pg1 p1 p2
$ovn-nbctl acl-add pg1 to-lport 2003 "inport==@pg1 && ip4 && ip4.src == 192.168.0.0/16 && udp && udp.dst == 9000" allow
$ovn-nbctl acl-add pg1 to-lport 2001 "inport==@pg1" reject
$ovn-trace 'inport == "p2" && eth.src == 00:00:00:00:00:03 && eth.dst == 00:00:00:00:00:02 && ip.ttl==42 && ip4.src == 192.168.0.3'
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2074537
Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Acked-by: Mark Michelson <mmichels@redhat.com>
Signed-off-by: Mark Michelson <mmichels@redhat.com>
putnopvut
pushed a commit
that referenced
this pull request
May 10, 2022
Avoid the following crash in ovn-trace due to a reject action infinite
loop:
AddressSanitizer:DEADLYSIGNAL
==569410==ERROR: AddressSanitizer: stack-overflow on address 0x7ffc0a991bc4 (pc 0x000000415081 bp 0x7ffc0a993fa0 sp 0x7ffc0a991b30 T0)
#0 0x415081 in trace_actions utilities/ovn-trace.c:2617
#1 0x41d878 in trace_actions utilities/ovn-trace.c:2622
#2 0x41d878 in trace__ utilities/ovn-trace.c:3007
#3 0x41e3a8 in execute_output utilities/ovn-trace.c:1700
#4 0x416fcf in trace_actions utilities/ovn-trace.c:2640
#5 0x41d878 in trace_actions utilities/ovn-trace.c:2622
#6 0x41d878 in trace__ utilities/ovn-trace.c:3007
#7 0x41788d in execute_next utilities/ovn-trace.c:2307
#8 0x41788d in trace_actions utilities/ovn-trace.c:2644
#9 0x41a7c0 in trace_actions utilities/ovn-trace.c:2622
#10 0x41a7c0 in execute_sctp4_abort utilities/ovn-trace.c:1985
#11 0x419671 in execute_reject utilities/ovn-trace.c:2049
#12 0x419671 in trace_actions utilities/ovn-trace.c:2860
#13 0x41d878 in trace_actions utilities/ovn-trace.c:2622
#14 0x41d878 in trace__ utilities/ovn-trace.c:3007
#15 0x41e3a8 in execute_output utilities/ovn-trace.c:1700
#16 0x416fcf in trace_actions utilities/ovn-trace.c:2640
#17 0x41d878 in trace_actions utilities/ovn-trace.c:2622
#18 0x41d878 in trace__ utilities/ovn-trace.c:3007
#19 0x41788d in execute_next utilities/ovn-trace.c:2307
#20 0x41788d in trace_actions utilities/ovn-trace.c:2644
#21 0x41a7c0 in trace_actions utilities/ovn-trace.c:2622
#22 0x41a7c0 in execute_sctp4_abort utilities/ovn-trace.c:1985
#23 0x419671 in execute_reject utilities/ovn-trace.c:2049
#24 0x419671 in trace_actions utilities/ovn-trace.c:2860
#25 0x41d878 in trace_actions utilities/ovn-trace.c:2622
#26 0x41d878 in trace__ utilities/ovn-trace.c:3007
#27 0x41e3a8 in execute_output utilities/ovn-trace.c:1700
#28 0x416fcf in trace_actions utilities/ovn-trace.c:2640
#29 0x41d878 in trace_actions utilities/ovn-trace.c:2622
#30 0x41d878 in trace__ utilities/ovn-trace.c:3007
#31 0x41788d in execute_next utilities/ovn-trace.c:2307
#32 0x41788d in trace_actions utilities/ovn-trace.c:2644
#33 0x41a7c0 in trace_actions utilities/ovn-trace.c:2622
#34 0x41a7c0 in execute_sctp4_abort utilities/ovn-trace.c:1985
#35 0x419671 in execute_reject utilities/ovn-trace.c:2049
#36 0x419671 in trace_actions utilities/ovn-trace.c:2860
#37 0x41d878 in trace_actions utilities/ovn-trace.c:2622
#38 0x41d878 in trace__ utilities/ovn-trace.c:3007
#39 0x41e3a8 in execute_output utilities/ovn-trace.c:1700
#40 0x416fcf in trace_actions utilities/ovn-trace.c:2640
#41 0x41d878 in trace_actions utilities/ovn-trace.c:2622
#42 0x41d878 in trace__ utilities/ovn-trace.c:3007
#43 0x41788d in execute_next utilities/ovn-trace.c:2307
....
The issue can be triggered with the following reproducer:
$ovn-nbctl ls-add sw
$ovn-nbctl lsp-add sw p1
$ovn-nbctl lsp-set-addresses p1 "00:00:00:00:00:02 192.168.0.2"
$ovn-nbctl lsp-add sw p2
$ovn-nbctl lsp-set-addresses p2 "00:00:00:00:00:03 192.168.0.3"
$ovn-nbctl pg-add pg1 p1 p2
$ovn-nbctl acl-add pg1 to-lport 2003 "inport==@pg1 && ip4 && ip4.src == 192.168.0.0/16 && udp && udp.dst == 9000" allow
$ovn-nbctl acl-add pg1 to-lport 2001 "inport==@pg1" reject
$ovn-trace 'inport == "p2" && eth.src == 00:00:00:00:00:03 && eth.dst == 00:00:00:00:00:02 && ip.ttl==42 && ip4.src == 192.168.0.3'
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2074537
Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Acked-by: Mark Michelson <mmichels@redhat.com>
Signed-off-by: Mark Michelson <mmichels@redhat.com>
putnopvut
pushed a commit
that referenced
this pull request
May 10, 2022
Avoid the following crash in ovn-trace due to a reject action infinite
loop:
AddressSanitizer:DEADLYSIGNAL
==569410==ERROR: AddressSanitizer: stack-overflow on address 0x7ffc0a991bc4 (pc 0x000000415081 bp 0x7ffc0a993fa0 sp 0x7ffc0a991b30 T0)
#0 0x415081 in trace_actions utilities/ovn-trace.c:2617
#1 0x41d878 in trace_actions utilities/ovn-trace.c:2622
#2 0x41d878 in trace__ utilities/ovn-trace.c:3007
#3 0x41e3a8 in execute_output utilities/ovn-trace.c:1700
#4 0x416fcf in trace_actions utilities/ovn-trace.c:2640
#5 0x41d878 in trace_actions utilities/ovn-trace.c:2622
#6 0x41d878 in trace__ utilities/ovn-trace.c:3007
#7 0x41788d in execute_next utilities/ovn-trace.c:2307
#8 0x41788d in trace_actions utilities/ovn-trace.c:2644
#9 0x41a7c0 in trace_actions utilities/ovn-trace.c:2622
#10 0x41a7c0 in execute_sctp4_abort utilities/ovn-trace.c:1985
#11 0x419671 in execute_reject utilities/ovn-trace.c:2049
#12 0x419671 in trace_actions utilities/ovn-trace.c:2860
#13 0x41d878 in trace_actions utilities/ovn-trace.c:2622
#14 0x41d878 in trace__ utilities/ovn-trace.c:3007
#15 0x41e3a8 in execute_output utilities/ovn-trace.c:1700
#16 0x416fcf in trace_actions utilities/ovn-trace.c:2640
#17 0x41d878 in trace_actions utilities/ovn-trace.c:2622
#18 0x41d878 in trace__ utilities/ovn-trace.c:3007
#19 0x41788d in execute_next utilities/ovn-trace.c:2307
#20 0x41788d in trace_actions utilities/ovn-trace.c:2644
#21 0x41a7c0 in trace_actions utilities/ovn-trace.c:2622
#22 0x41a7c0 in execute_sctp4_abort utilities/ovn-trace.c:1985
#23 0x419671 in execute_reject utilities/ovn-trace.c:2049
#24 0x419671 in trace_actions utilities/ovn-trace.c:2860
#25 0x41d878 in trace_actions utilities/ovn-trace.c:2622
#26 0x41d878 in trace__ utilities/ovn-trace.c:3007
#27 0x41e3a8 in execute_output utilities/ovn-trace.c:1700
#28 0x416fcf in trace_actions utilities/ovn-trace.c:2640
#29 0x41d878 in trace_actions utilities/ovn-trace.c:2622
#30 0x41d878 in trace__ utilities/ovn-trace.c:3007
#31 0x41788d in execute_next utilities/ovn-trace.c:2307
#32 0x41788d in trace_actions utilities/ovn-trace.c:2644
#33 0x41a7c0 in trace_actions utilities/ovn-trace.c:2622
#34 0x41a7c0 in execute_sctp4_abort utilities/ovn-trace.c:1985
#35 0x419671 in execute_reject utilities/ovn-trace.c:2049
#36 0x419671 in trace_actions utilities/ovn-trace.c:2860
#37 0x41d878 in trace_actions utilities/ovn-trace.c:2622
#38 0x41d878 in trace__ utilities/ovn-trace.c:3007
#39 0x41e3a8 in execute_output utilities/ovn-trace.c:1700
#40 0x416fcf in trace_actions utilities/ovn-trace.c:2640
#41 0x41d878 in trace_actions utilities/ovn-trace.c:2622
#42 0x41d878 in trace__ utilities/ovn-trace.c:3007
#43 0x41788d in execute_next utilities/ovn-trace.c:2307
....
The issue can be triggered with the following reproducer:
$ovn-nbctl ls-add sw
$ovn-nbctl lsp-add sw p1
$ovn-nbctl lsp-set-addresses p1 "00:00:00:00:00:02 192.168.0.2"
$ovn-nbctl lsp-add sw p2
$ovn-nbctl lsp-set-addresses p2 "00:00:00:00:00:03 192.168.0.3"
$ovn-nbctl pg-add pg1 p1 p2
$ovn-nbctl acl-add pg1 to-lport 2003 "inport==@pg1 && ip4 && ip4.src == 192.168.0.0/16 && udp && udp.dst == 9000" allow
$ovn-nbctl acl-add pg1 to-lport 2001 "inport==@pg1" reject
$ovn-trace 'inport == "p2" && eth.src == 00:00:00:00:00:03 && eth.dst == 00:00:00:00:00:02 && ip.ttl==42 && ip4.src == 192.168.0.3'
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2074537
Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Acked-by: Mark Michelson <mmichels@redhat.com>
Signed-off-by: Mark Michelson <mmichels@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ovn-northd-ddlog depends on
libopenvswitch.aandlibovn.a.Therefore, when we compile a standalone executable (enabled by the
--enable-ddlog-northd-cliswitch toconfigure), it must be linkedagainst these libraries and their dependencies. The latter is tricky,
since
cargo(the Rust build system) does not understand libtool files,so we don't have an easy way to pull in dependencies automatically.
Until now, we dealt with this by manually listing dependencies in the
cargocommand line. This no longer works as OVS now has at least oneconfigurable dependency, the
libunwind.alibrary, that is enabled bythe OVS configuration script. This results is link errors with the latest
version of OVS.
The only solution I could come up with is to extract dependencies from
libopenvswitch.aandlibovn.ausinggrepand pass them to cargo.