debian: Initial packaging for OVN

[javacruft]

Update debian packaging folder based on packaging work
completed in Ubuntu.

[numansiddique]

@javacruft Thanks for the PR.

The build is failing for me locally (and probably in travis CI too) with the below errors. Can you please check it. If you can submit the patch to the ovs-dev ML that would be great. No worries otherwise.

---

/bin/sh /home/nusiddiq/workspace_cpp/ovn-org/ovn-for-reviews/ovn/build-aux/missing autom4te --language=autotest -I '..' -o ../tests/system-kmod-testsuite.tmp ../tests/system-kmod-testsuite.at
/bin/sh /home/nusiddiq/workspace_cpp/ovn-org/ovn-for-reviews/ovn/build-aux/missing autom4te --language=autotest -I '..' -o ../tests/system-userspace-testsuite.tmp ../tests/system-userspace-testsuite.at
The following files are in git but not the distribution:
debian/ovn-ic-db.install
debian/ovn-ic-db.manpages
debian/ovn-ic-db.ovn-ovsdb-server-ic-nb.service
debian/ovn-ic-db.ovn-ovsdb-server-ic-sb.service
debian/ovn-ic-db.service
debian/ovn-ic.install
debian/ovn-ic.manpages
debian/ovn-ic.service
make[1]: *** [Makefile:2909: dist-hook-git] Error 1
make[1]: *** Waiting for unfinished jobs....
mv ../tests/system-kmod-testsuite.tmp ../tests/system-kmod-testsuite
mv ../tests/system-userspace-testsuite.tmp ../tests/system-userspace-testsuite
mv ../tests/testsuite.tmp ../tests/testsuite
make[1]: Leaving directory '/home/nusiddiq/workspace_cpp/ovn-org/ovn-for-reviews/ovn/_gcc'
make: *** [Makefile:1329: all] Error 2
make: Leaving directory '/home/nusiddiq/workspace_cpp/ovn-org/ovn-for-reviews/ovn/_gcc'

---

[javacruft]

I might try to change the way the automake inclusions work - there is really no need to include all of the files in the debian directory in the way its done today. However I think as an initial set of Debian packaging this is good to go. It does require an openvswitch-source package that we produce from the openvswitch packaging in Ubuntu - I'll also be raising a PR for OVS for that work.

[numansiddique]

Could you please provide your Signed-off-by tag ?

After that I'll post the patch to ovs-dev ML to get some comments.
I'm not a debian developer and I've no experience with debian packaging.

Thanks
Numan

[shettyg]

@javacruft Will this be compatible with debian packages that are generated from openvswitch repo? As you know, the ones in openvswitch do not have systemd.

[javacruft]

@javacruft Will this be compatible with debian packages that are generated from openvswitch repo? As you know, the ones in openvswitch do not have systemd.

Not yet - I made some changes in Ubuntu specifically:

• addition of the openvswitch-source package to support the OVN build
• move of the ovsdb-server and ovsdb-tool binaries into openvswitch-common to avoid a dependency from ovn-* to openvswitch-switch

I'll raise a separate change to support that this week.

[shettyg]

Not yet - I made some changes in Ubuntu specifically:

addition of the openvswitch-source package to support the OVN build
move of the ovsdb-server and ovsdb-tool binaries into openvswitch-common to avoid a dependency from ovn-* to openvswitch-switch
I'll raise a separate change to support that this week.

@javacruft Any changes to OVS debian packages should support upgrades from previous versions.

[fnordahl]

@javacruft Will this be compatible with debian packages that are generated from openvswitch repo? As you know, the ones in openvswitch do not have systemd.

I'm not quite sure what you are aiming at here @shettyg. The traditional System V init scripts that currently ship with Open vSwitch will on both Debian and Ubuntu automatically get a entry point from systemd with help from systemd-sysv-generator.

For OVN the existing System V init scripts do not cut it for deploying OVN with clustered OVSDB servers and TLS enabled with spread placement of databases to name one thing. A side effect of providing configuration for ovn-northd is that databases will no longer be started at all

Instead of relying on external tools to provide magic to connect the aging System V scripts to the current world order, we are leveraging the power available in current tooling to enable you to make the most of the wonderful things the communities of Open vSwitch and Open Virtual Network projects produce every day.

[shettyg]

@fnordahl

It is perfectly fine to use systemd for OVN. Just that, it has to be tested with debian packages generated from OVS repo and not the debian packages that Ubuntu upstream creates for OVS. In the past, when I have tested the debian packages created by Ubuntu upstream (which is different than what OVS repo has), there were a few bugs. For e.g., it would not work with OVS integration with ifupdown. We had to put the following in OVS sysV scripts to make sure that the features work.

_SYSTEMCTL_SKIP_REDIRECT=yes
SYSTEMCTL_SKIP_REDIRECT=yes

[shettyg]

It is also fine to invest time to move debian packages in OVS repo to move to systemd too -if that is a blocker for any reason. (I think the rhel/fedora devs have done a good job with systemd integration and OVS - in OVS repo's rhel directory and a lot of it can be re-used).

[fnordahl]

@fnordahl

It is perfectly fine to use systemd for OVN. Just that, it has to be tested with debian packages generated from OVS repo and not the debian packages that Ubuntu upstream creates for OVS. In the past, when I have tested the debian packages created by Ubuntu upstream (which is different than what OVS repo has), there were a few bugs. For e.g., it would not work with OVS integration with ifupdown. We had to put the following in OVS sysV scripts to make sure that the features work.

_SYSTEMCTL_SKIP_REDIRECT=yes
SYSTEMCTL_SKIP_REDIRECT=yes

We would love to hear all about it.

It is also fine to invest time to move debian packages in OVS repo to move to systemd too -if that is a blocker for any reason. (I think the rhel/fedora devs have done a good job with systemd integration and OVS - in OVS repo's rhel directory and a lot of it can be re-used).

The Ubuntu packages already have systemd units, and this endeavor is all about upstreaming that. I'm sure we have shared notes with our friends at Fedora already, that's what this OSS thing is all about :)

[javacruft]

Not yet - I made some changes in Ubuntu specifically:

addition of the openvswitch-source package to support the OVN build
move of the ovsdb-server and ovsdb-tool binaries into openvswitch-common to avoid a dependency from ovn-* to openvswitch-switch
I'll raise a separate change to support that this week.

@javacruft Any changes to OVS debian packages should support upgrades from previous versions.

Absolutely and something I'm always aware of - any proposed changes would support in-place upgrades of existing deployments without having to uninstall first. The moves are fairly simple and just required a few Breaks/Replaces on the impacted binary packages.

[javacruft]

It is also fine to invest time to move debian packages in OVS repo to move to systemd too -if that is a blocker for any reason. (I think the rhel/fedora devs have done a good job with systemd integration and OVS - in OVS repo's rhel directory and a lot of it can be re-used).

ifupdown is one consideration here - later Ubuntu versions don't use ifupdown by default but netplan lacks OVS support (there is work happening in that area but its not ready yet) so it does present a bit of a gap compared to older releases so I'd prefer to split any systemd work from updates to the OVS repo to support OVN packaging which I think is entirely sensible.

[numansiddique]

What's the status of this PR ?

Does it needs more work or we can merge it ?

Thanks

[ateleshev]

Previous varian was more flexible, I think, it will be better to use $(DATAPATH_CONFIGURE_OPTS) for parameters defining

RUN DATADIR="/usr/share/ovn" \
    DATAPATH_CONFIGURE_OPTS="--with-ovs-source=${OVS_SRC} --with-ovs-build=${OVS_SRC}" \
    DEB_BUILD_OPTIONS="parallel=8 nocheck" \
    fakeroot debian/rules binary

[numansiddique]

This PR is inactive since a long time. Closing it. Feel free to reopen it if it is still valid.

Thanks
Numan