[PWCI] "net/mlx5: release allocated indexed pools" #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cited commit allocated indexped pools but those pools were never released. Fix it. Fixes: b4edeaf ("net/mlx5: replace flow list with indexed pool") Cc: stable@dpdk.org Signed-off-by: Roi Dayan <roid@nvidia.com> Acked-by: Bing Zhao <bingz@nvidia.com> Signed-off-by: 0-day Robot <robot@bytheb.org>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds mechanism to release indexed flow pools by introducing a dedicated cleanup function and invoking it during device shutdown. Sequence diagram for device close and flow pool cleanupsequenceDiagram
participant "mlx5_dev_close()"
participant "mlx5_flow_pools_destroy()"
participant "mlx5_ipool_destroy()"
"mlx5_dev_close()"->>"mlx5_flow_pools_destroy()": Call during device close
loop For each flow pool in priv->flows
"mlx5_flow_pools_destroy()"->>"mlx5_ipool_destroy()": Destroy non-null pool
end
Class diagram for updated mlx5_priv flow pool managementclassDiagram
class mlx5_priv {
flows[MLX5_FLOW_TYPE_MAXI]: ipool*
domain_id: int
...
}
class mlx5_flow_pools_destroy {
+mlx5_flow_pools_destroy(priv: mlx5_priv*)
}
mlx5_flow_pools_destroy --> mlx5_priv : uses
class mlx5_ipool_destroy {
+mlx5_ipool_destroy(ipool*)
}
mlx5_flow_pools_destroy --> mlx5_ipool_destroy : calls
mlx5_priv "1" o-- "MLX5_FLOW_TYPE_MAXI" ipool : flows array
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Consider resetting priv->flows[i] to NULL after calling mlx5_ipool_destroy to avoid dangling pointers in the private data.
- Ensure mlx5_flow_pools_destroy is invoked in any early error‐exit paths during flow pool setup so partial initialization failures don’t leak pools.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider resetting priv->flows[i] to NULL after calling mlx5_ipool_destroy to avoid dangling pointers in the private data.
- Ensure mlx5_flow_pools_destroy is invoked in any early error‐exit paths during flow pool setup so partial initialization failures don’t leak pools.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
WalkthroughAdds a static mlx5_flow_pools_destroy(priv) to free flow IP pools and invokes it from mlx5_dev_close() to ensure pools are destroyed during device close. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant App
participant Driver as mlx5_dev_close()
participant Pools as mlx5_flow_pools_destroy()
participant IPool as mlx5_ipool_destroy()
App->>Driver: close device
Driver->>Pools: destroy flow pools
loop for i in [0..MLX5_FLOW_TYPE_MAXI)
alt priv->flows[i] != NULL
Pools->>IPool: mlx5_ipool_destroy(priv->flows[i])
IPool-->>Pools: freed
else
note over Pools: skip null entry
end
end
Pools-->>Driver: done
Driver-->>App: close complete
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧬 Code graph analysis (1)drivers/net/mlx5/mlx5.c (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This is an auto submission for "net/mlx5: release allocated indexed pools".
See "http://patchwork.dpdk.org/project/dpdk/list/?series=36292" for details.
Summary by Sourcery
Add cleanup of allocated indexed pools for flow resources on device close to prevent memory leaks
Bug Fixes:
Enhancements:
Summary by CodeRabbit