Add support for disabling test cases. #1513
Conversation
|
Hi @lkarsten, By the end of each test execution we have this summary where we show the amount of tests, and the respective results: skipped, passed, failed. Currently we just count the skipped ones if they are disabled due to a missing dependency. It would be great to have the ones disabled via JSON, to also appear in the skip summary. What do you think? |
|
Hi. I think that makes sense. I'll look into it next week and (if successful) propose a new patch here. |
|
@lkarsten thank you :) |
The JSON test case format has an "enabled" key that is not currently being honored. This trivial patch adds support for skipping test cases that has enabled set to 0.
This commit adds support for skipping test cases that have enabled=0 in their JSON body. A separate counter is kept and reported in the final non-automake output, detailing disabled as a separate field. Ref: owasp-modsecurity#1513
|
Hello again. I've force-pushed a new patch now. It implements skipping the disabled ones as well as a count in the end. Please consider this for merging into v3/master. |
|
Hello. Have you had the chance to look at this? |
|
Merged tahnks ;) Just did a small fix to count the disabled test as `skip' in the test summary. |
This commit adds support for skipping test cases that have enabled=0 in their JSON body. A separate counter is kept and reported in the final non-automake output, detailing disabled as a separate field. Ref: #1513
|
Thanks :-) |
The JSON test case format has an "enabled" key that is not
currently being honored. This trivial patch adds support for skipping
test cases that has enabled set to 0.