Disallow 'block' as a default action #1614
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, it is possible to specify 'block' as the default disruptive action for any phase. If there is a rule for a phase with default action 'block' which in turn uses 'block' as its disruptive action, i.e., wants to use the default disruptive action, and the rule gets triggered, libmodsecurity enters an infinite recursion with subsequent segmentation violation. Include a regression test for this scenario.
zimmerle
pushed a commit
that referenced
this pull request
Feb 28, 2018
|
Thank you for the patch. Indeed the segfault is not welcomed. However, we still need to have the block working in the same fashion that we had on v2. Therefore, I have proposed a different fix. Available here: 6842d4b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it is possible to specify 'block' as the default disruptive
action for any phase. If there is a rule for a phase with default
action 'block' which in turn uses 'block' as its disruptive action,
i.e., wants to use the default disruptive action, and the rule gets
triggered, libmodsecurity enters an infinite recursion with subsequent
segmentation violation.
Include a regression test for this scenario.