Initialize invalid_count in UrlDecode::evaluate #1755
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The other caller of urldecode_nonstrict_inplace initialized the third param, but UrlDecode::evaluate did not.
|
Do you mind to describe what is the point to initialize it? |
|
Good practice, since the value is unused in this context it doesn't have an impact on control flow. It's largely a quality issue (and keeping its usage in line with the other caller is good for code review purposes IMO). |
|
Same as #1756 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The other caller of urldecode_nonstrict_inplace initialized the third param, but UrlDecode::evaluate did not.