Ignore (consistently) empty actions #3003
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case we write a rule with an empty action, like the following
SecRule {pattern} {target} "action1,action2,,action3"
the behaviour is not consistent.
Preliminary explanation: although having empty actions is abnormal, it may happen very easily when using mod_macro, mod_define or to activate some actions or not depending on the context.
Behaviour:
This PR adds a trivial check to not store empty actions in the table and have a consistent behaviour.