Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better not to use JSValue as type alias #1

Closed
liaojinxing opened this issue Jun 23, 2014 · 0 comments
Closed

Better not to use JSValue as type alias #1

liaojinxing opened this issue Jun 23, 2014 · 0 comments

Comments

@liaojinxing
Copy link

https://github.com/owensd/json-swift/blob/master/JSON/JSON.swift#L11
typealias JSValue = JSON

JSValue is defined in JavaScriptCore.framework. A JSValue is a reference to a value within the JavaScript object space of a JSVirtualMachine. Therefore, I think it's better to use another alias to avoid confusion.
owensd added a commit that referenced this issue Jun 23, 2014
@owensd
Fix for issue #1 - prefix types with JSON instead of JS
d26de71 
Added Printable interface implementation
Marked Invalid as a "private" member
Header documentation for most public functions.
@owensd owensd closed this as completed Jun 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@owensd @liaojinxing