Upgrade to Storybook 6 #535
Merged
+2,219
−2,559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breck7
reviewed
Aug 9, 2020
| @@ -31,7 +31,7 @@ | |||
| "serve": "yarn tsn admin/server/server.tsx", | |||
| "bake": "yarn tsn scripts/bakeSite.ts", | |||
| "deploy-queue": "yarn tsn deploy/watch.ts", | |||
| "storybook": "yarn tsn node_modules/.bin/start-storybook -p 6006", | |||
| "storybook": "start-storybook -p 6006", | |||
There was a problem hiding this comment.
I think this means the new Storybook respects tsconfig settings. Neat!
breck7
reviewed
Aug 9, 2020
| @@ -100,7 +100,8 @@ class ChartStoryView extends React.Component { | |||
| } | |||
|
|
|||
| export default { | |||
| title: "ChartView" | |||
| title: "ChartView", | |||
| component: ChartView | |||
There was a problem hiding this comment.
What's this new component property?
There was a problem hiding this comment.
This is used to auto-generate documentation for the props: https://github.com/storybookjs/storybook/blob/next/addons/docs/react/README.md#props-tables
Looks like this:
breck7
approved these changes
Aug 9, 2020
also enable some new addons
marcelgerber
force-pushed
the
storybook-6
branch
from
e8be7c5 to
23b43a9
Compare
|
Just updated to the just-released storybook 6.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades our storybook version to 6.0, which is currently a release candidate but is scheduled to come out... tomorrow (storybookjs/storybook#9311)!
This gives us out-of-the-box TS support and a nicer way to configure things.
I've also enabled some more addons using the new
@storybook/essentialspackage:addon-docsauto-generates the props of our componentsaddon-actionswas enabled beforeaddon-controlslets us control the props of the component to play around with itaddon-viewportlets us view a component in different viewports