Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple definitions failure is too strict? #752

Closed
bjonnh opened this issue Apr 21, 2018 · 3 comments
Closed

Multiple definitions failure is too strict? #752

bjonnh opened this issue Apr 21, 2018 · 3 comments
Labels

Comments

@bjonnh
Copy link

bjonnh commented Apr 21, 2018

I was trying to import some terms from ENVO using the ontology-starter-kit.

Owltools fail converting that to OBO. (see the issue I submitted for owltools) : owlcollab/owltools#248

In ENVO, IAO and BFO, terms have multiple IAO_0000115 (definition), one being annotated as being an axiom.

So my question here is: Is OWLAPI too strict here?

@ignazio1977
Copy link
Contributor

It might be that this is too strict in real life applications, however this is part of the OBO specs so it needs OBO experts to weigh in. @cmungall what do you think?

@cmungall
Copy link
Member

This can be switched off with setCheckStructure(false), in which case behavior with multiple text defs is undefined after roundtripping (one will text def will be dropped).

I followed up on your ticket here:
owlcollab/owltools#248

Both owltools and robot now have commands to pass in an override to strict mode on the command line.

I'll follow up with @pbuttigieg to fix ENVO as this shouldn't be happening. Regardless of the format used, we should have a single text definition. This can be violated either by accident or by superimposing different versions of the same ontology through stale imports. Previously the only check we have against this was the obo conversion, but in the next release of robot we'll have sparql checks so that people get this QC regardless of conversion.

cmungall added a commit to INCATools/ontology-development-kit that referenced this issue Apr 22, 2018
This requires the changes in ontodev/robot#64 which is not in the latest release yet

For discussion see owlcs/owlapi#752
@bjonnh
Copy link
Author

bjonnh commented Apr 23, 2018

Thanks, I switched to robot in my makefiles (not everywhere yet though).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants