Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support versions of ffmpeg greater than 5 #3476

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Conversation

gabek
Copy link
Member

@gabek gabek commented Dec 11, 2023

This splits out vaapi codec into two completely different options. Vaapi (Legacy) is what has always existed in Owncast, and supports ffmpeg versions older than 5. Vaapi is the new, up-to-date support for Vaapi and requires support for ffmpeg v5 and above.

When running this code it will migrate you from using vaapi to Vaapi (Legacy), making the assumption if you were using vaapi before you were also using an older version of ffmpeg. If you need to change it to the new version, you must manually make that change.

Copy link

cypress bot commented Dec 11, 2023

Passing run #12248 ↗︎

0 87 0 0 Flakiness 0

Details:

Merge 4f7d25f into 9d68090...
Project: Owncast Web Frontend Commit: eb3557aa07 ℹ️
Status: Passed Duration: 04:19 💡
Started: Dec 17, 2023 10:36 PM Ended: Dec 17, 2023 10:40 PM

Review all test suite changes for PR #3476 ↗︎

@gabek gabek linked an issue Dec 18, 2023 that may be closed by this pull request
@gabek gabek marked this pull request as ready for review December 18, 2023 23:51
@gabek gabek mentioned this pull request Dec 18, 2023
@gabek gabek changed the title WIP Support versions of ffmpeg greater than 5 Support versions of ffmpeg greater than 5 Dec 18, 2023
@gabek
Copy link
Member Author

gabek commented Dec 23, 2023

Note: Ignore the conflicts, the web project was built for this PR just for testing. It will be reverted before it gets merged in.

Copy link

stale bot commented Mar 13, 2024

This pull request has not had any activity in 30 days. Since things move fast it's best to get PRs merged in. If this PR addresses a previously filed issue that needs to be resolved please work to get it merged in, or allow somebody else to work on a fix. This PR will be closed if no further activity occurs. Thank you for your contributions!

@stale stale bot added the stale label Mar 13, 2024
@gabek gabek removed the stale label Mar 13, 2024
@Hasmuni5757
Copy link

Meer

@gabek
Copy link
Member Author

gabek commented Mar 17, 2024

Meer

Could you add detail to your comment?

Copy link

cypress bot commented Apr 10, 2024

2 failed tests on run #16078 ↗︎

2 85 0 0 Flakiness 0

Details:

fix(video): remove vaapi presets and add compression level
Project: Owncast Web Frontend Commit: 926287881e
Status: Failed Duration: 04:26 💡
Started: Apr 10, 2024 11:54 PM Ended: Apr 10, 2024 11:59 PM
Failed  cypress/e2e/online/03_online_readwrite_chat_embed.cy.js • 2 failed tests • mobile-online

View Output Video

Test Artifacts
Online readwrite chat embed > Show change name modal Screenshots Video
Online readwrite chat embed > Close name change modal Screenshots Video

Review all test suite changes for PR #3476 ↗︎

@Ravenslofty
Copy link

I can't test this because the video configuration page is uninteractable due to loading /_next/static/chunks/pages/admin/config-video-48cdaf1ab8e0b92f.js which doesn't exist; what do I do?

@gabek
Copy link
Member Author

gabek commented Aug 3, 2024

Hi there, unfortunately this is paused. Please follow the thread over at #2071 for more details.

@Ravenslofty
Copy link

Yes, I saw that, but in light of #2071 (comment) I was hoping I could provide something of use in the form of testing and feedback to the project.

@gabek
Copy link
Member Author

gabek commented Aug 3, 2024

I appreciate you wanting to help, but please do read the rest to get up to date. This work is paused due to issues, and unfortunately testing and feedback isn't going to fix it at this point in time. But I do appreciate you wanting to help, and I hope you'll be wanting to help in other ways! #2071 (comment)

Copy link

github-actions bot commented Oct 7, 2024

This pull request has not had any activity in 30 days. If it has been abandoned no future actions are necessary, it will be automatically closed. If this is a PR with no clear plan on how to move forward on it getting into the project, then further discussion is needed. Now is a good time to discuss if this is still something that should be worked on. If this PR is idle simply because nobody has reviewed it, then feel free to ping somebody. However, if this PR is not linked to an existing issue regarding something that was previously determined to be important, then even more discussion needs to take place before it can get anywhere. This PR will be closed if no further activity occurs. Thank you for your contributions!

@github-actions github-actions bot added the stale label Oct 7, 2024
@gabek gabek removed the stale label Oct 7, 2024
@gabek
Copy link
Member Author

gabek commented Oct 7, 2024

Not stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ffmpeg 6
3 participants