This repository was archived by the owner on Feb 20, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 166
document new dependency tags in info.xml #706
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,6 +43,19 @@ The :file:`appinfo/info.xml` contains metadata about the app: | |
|
||
<default_enable /> | ||
<shipped>true</shipped> | ||
|
||
<dependencies> | ||
<php min-version="5.4" max-version="5.5"/> | ||
<database>sqlite</database> | ||
<database>mysql</database> | ||
<command os="linux">grep</command> | ||
<command os="windows">notepad.exe</command> | ||
<lib min-version="1.2">xml</lib> | ||
<lib max-version="2.0">intl</lib> | ||
<lib>curl</lib> | ||
<os>Linux</os> | ||
<owncloud min-version="6.0.4" max-version="8"/> | ||
</dependencies> | ||
</info> | ||
|
||
id | ||
|
@@ -96,7 +109,41 @@ link to 'admin' and 'user' documentation | |
|
||
website | ||
------- | ||
link to project webpage | ||
link to project web page | ||
|
||
Dependencies | ||
============ | ||
All tags within the dependencies tag define a set of requirements which have to be fulfilled in order to operate | ||
properly. As soon as one of these requirements is not met the app cannot be installed. | ||
|
||
php | ||
--- | ||
Defines the minimum and the maximum version of php which is required to run this app. | ||
|
||
database | ||
-------- | ||
Each supported database has to be listed in here. Valid values are sqlite, mysql, pgsql, oci and mssql. In the future | ||
it will be possible to specify versions here as well. | ||
In case no database is specified it is assumed that all databases are supported. | ||
|
||
command | ||
------- | ||
Defines a command line tool to be available. With the attribute 'os' the required operating system for this tool can be | ||
specified. Valid values for the 'os' attribute are as returned by the php function `php_uname http://php.net/manual/en/function.php-uname.php`_. | ||
|
||
lib | ||
--- | ||
Defines a required php extension with required minimum and/or maximum version. The names for the libraries have to match the result as returned by the php function `get_loaded_extensions http://php.net/manual/en/function.get-loaded-extensions.php`_. | ||
The explicit version of an extension is read from `phpversion http://php.net/manual/de/function.phpversion.php`_ - with some exception as to be read up in the code base `https://github.com/owncloud/core/blob/master/lib/private/app/platformrepository.php#L45`_ | ||
|
||
os | ||
-- | ||
Defines the required target operating system the app can run on. Valid values are as returned by the php function `php_uname http://php.net/manual/en/function.php-uname.php`_. | ||
|
||
owncloud | ||
-------- | ||
Defines minimum and maximum versions of the ownCloud core. In case undefined the values will be taken from the tag 'requiremin'. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In case of undefined -> In case no values are provided There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. also requiremax and require i guess There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. well - requiremax is not document and therefore to be ignored from my pov 🙊 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I see, yes makes sense |
||
|
||
|
||
Deprecated | ||
========== | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd remove the "in the future hint". It is not yet implemented and I'd wait for a feature request to actually implement it