New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #136 [Feature] Instant upload of videos #149

Merged
merged 12 commits into from Apr 22, 2014

Conversation

Projects
None yet
@zerginator
Contributor

zerginator commented May 1, 2013

Issue #136 [Feature] Instant upload of videos

@zerginator

This comment has been minimized.

Show comment
Hide comment
@zerginator

zerginator May 1, 2013

Contributor

finally something worked ;-)

Contributor

zerginator commented May 1, 2013

finally something worked ;-)

@zerginator

This comment has been minimized.

Show comment
Hide comment
@zerginator

zerginator May 1, 2013

Contributor

I noticed that the included media player of owncloud ( not the android app) doesn't play mp4 videos.

Contributor

zerginator commented May 1, 2013

I noticed that the included media player of owncloud ( not the android app) doesn't play mp4 videos.

@zerginator

This comment has been minimized.

Show comment
Hide comment
@zerginator

zerginator May 1, 2013

Contributor

I included a check that Upload is only allowed when the app has a connection with wifi. Otherwise it would cost the user a lot of quota and he wouldn't recognize it because the upload will happen in the background.

Contributor

zerginator commented May 1, 2013

I included a check that Upload is only allowed when the app has a connection with wifi. Otherwise it would cost the user a lot of quota and he wouldn't recognize it because the upload will happen in the background.

@davivel

This comment has been minimized.

Show comment
Hide comment
@davivel

davivel May 3, 2013

Member

Better this waits a little. We have things to fix in the current instant upload of images before going with more instant uploads.

Member

davivel commented May 3, 2013

Better this waits a little. We have things to fix in the current instant upload of images before going with more instant uploads.

@dsg22

This comment has been minimized.

Show comment
Hide comment
@dsg22

dsg22 Jul 28, 2013

@zerginator thanks for your work on this useful feature!

Regarding only uploading using wifi, any chance that could be made a configuration option? It makes this feature not very useful for me. A very useful case for such a feature would be for protests/demonstrations where video evidence of the event is desired, but phones may be confiscated and video deleted. In those cases one rarely has access to wifi.

dsg22 commented Jul 28, 2013

@zerginator thanks for your work on this useful feature!

Regarding only uploading using wifi, any chance that could be made a configuration option? It makes this feature not very useful for me. A very useful case for such a feature would be for protests/demonstrations where video evidence of the event is desired, but phones may be confiscated and video deleted. In those cases one rarely has access to wifi.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost commented Jul 28, 2013

+1

Show outdated Hide outdated AndroidManifest.xml
@enoch85

This comment has been minimized.

Show comment
Hide comment
@enoch85

enoch85 Aug 7, 2013

Member

👍 please merge this soon

Member

enoch85 commented Aug 7, 2013

👍 please merge this soon

@davivel

This comment has been minimized.

Show comment
Hide comment
@davivel

davivel Aug 12, 2013

Member

Sorry, but we won't merge this until main problems with instant upload of images are fixed.

That will be soon, fortunately.

Member

davivel commented Aug 12, 2013

Sorry, but we won't merge this until main problems with instant upload of images are fixed.

That will be soon, fortunately.

@vip9

This comment has been minimized.

Show comment
Hide comment
@vip9

vip9 Sep 5, 2013

Some code (MediaService.java) depends of API level 17, so what's the big deal?

vip9 commented Sep 5, 2013

Some code (MediaService.java) depends of API level 17, so what's the big deal?

@LukeOwlclaw

This comment has been minimized.

Show comment
Hide comment
@LukeOwlclaw

LukeOwlclaw Sep 6, 2013

Contributor

@vip9 Not sure, but I am assuming you are referring to my comment.

Every Android version from Android 2.2 is supported by the ownCloud app. More details: #110 (comment)

Contributor

LukeOwlclaw commented Sep 6, 2013

@vip9 Not sure, but I am assuming you are referring to my comment.

Every Android version from Android 2.2 is supported by the ownCloud app. More details: #110 (comment)

@vip9

This comment has been minimized.

Show comment
Hide comment
@vip9

vip9 Sep 6, 2013

As I see, the code in https://github.com/owncloud/android/blob/master/src/com/owncloud/android/media/MediaService.java#L160 refers to statics introduced in level 17 (e.g. MediaPlayer.MEDIA_ERROR_UNSUPPORTED)

So what's the problem with using more code newer (same) as level 14? (It won't compile anyway)

vip9 commented Sep 6, 2013

As I see, the code in https://github.com/owncloud/android/blob/master/src/com/owncloud/android/media/MediaService.java#L160 refers to statics introduced in level 17 (e.g. MediaPlayer.MEDIA_ERROR_UNSUPPORTED)

So what's the problem with using more code newer (same) as level 14? (It won't compile anyway)

@davivel

This comment has been minimized.

Show comment
Hide comment
@davivel

davivel Sep 24, 2013

Member

@vip9, the problem pointed by @LukeOwncloud is not adding a constant of API 17, but removing the old event. In the current version 1.4.5 both are used, each of them for different Android versions.

Anyway, the reason why we don't want to add instant upload of videos by now is that instant upload of pictures needs to be fixed in several aspects. We don't want the same problems appear in the upload of videos, specially because they use to be bigger files.

Member

davivel commented Sep 24, 2013

@vip9, the problem pointed by @LukeOwncloud is not adding a constant of API 17, but removing the old event. In the current version 1.4.5 both are used, each of them for different Android versions.

Anyway, the reason why we don't want to add instant upload of videos by now is that instant upload of pictures needs to be fixed in several aspects. We don't want the same problems appear in the upload of videos, specially because they use to be bigger files.

@jancborchardt

This comment has been minimized.

Show comment
Hide comment
@jancborchardt

jancborchardt Dec 10, 2013

Member

What’s the resolution on this? It has been 7 months, @davivel @masensio @rperezb @MTRichards we need to manage community contributions better. :)

Member

jancborchardt commented Dec 10, 2013

What’s the resolution on this? It has been 7 months, @davivel @masensio @rperezb @MTRichards we need to manage community contributions better. :)

@davivel

This comment has been minimized.

Show comment
Hide comment
@davivel

davivel Dec 10, 2013

Member

This will be merged into develop soon, maybe before the end of the year.

Member

davivel commented Dec 10, 2013

This will be merged into develop soon, maybe before the end of the year.

@rperezb

This comment has been minimized.

Show comment
Hide comment
@rperezb

rperezb Dec 16, 2013

Member

@jancborchardt you are right, it is our goal for 2014 to manage better community contributions.

As @davivel already said, this is on our top of the priorities. I would expect it before February :), December is a busy month

Member

rperezb commented Dec 16, 2013

@jancborchardt you are right, it is our goal for 2014 to manage better community contributions.

As @davivel already said, this is on our top of the priorities. I would expect it before February :), December is a busy month

@jancborchardt

This comment has been minimized.

Show comment
Hide comment
@jancborchardt

jancborchardt Dec 16, 2013

Member

Cool! :)

Member

jancborchardt commented Dec 16, 2013

Cool! :)

@masensio

This comment has been minimized.

Show comment
Hide comment
@masensio

masensio Feb 19, 2014

@zerginator In these weeks we plan to merge your code about Instant Videos with develop. But the current version can't be merge automatically in develop. Could you please update this with the last changes?

Thanks for your patience.

masensio commented Feb 19, 2014

@zerginator In these weeks we plan to merge your code about Instant Videos with develop. But the current version can't be merge automatically in develop. Could you please update this with the last changes?

Thanks for your patience.

@enoch85

This comment has been minimized.

Show comment
Hide comment
@enoch85

enoch85 Feb 22, 2014

Member

Just a question. You talked about merging this in february, how is it going? When will this feature come to be realesed for real?

Member

enoch85 commented Feb 22, 2014

Just a question. You talked about merging this in february, how is it going? When will this feature come to be realesed for real?

@davivel

This comment has been minimized.

Show comment
Hide comment
@davivel

davivel Mar 13, 2014

Member

It's not going too well. No idea when it will be released. My apologies. Not enough time to test everything.

Member

davivel commented Mar 13, 2014

It's not going too well. No idea when it will be released. My apologies. Not enough time to test everything.

@masensio

This comment has been minimized.

Show comment
Hide comment
@masensio

masensio Apr 8, 2014

Now, this branch is updated with our develop branch.

masensio commented Apr 8, 2014

Now, this branch is updated with our develop branch.

@fduraibi

This comment has been minimized.

Show comment
Hide comment
@fduraibi

fduraibi Apr 14, 2014

👍 i want this feature, and if possible an option to allow the user to pick between: Photo only, video only or both.

fduraibi commented Apr 14, 2014

👍 i want this feature, and if possible an option to allow the user to pick between: Photo only, video only or both.

@davivel

This comment has been minimized.

Show comment
Hide comment
@davivel

davivel Apr 16, 2014

Member

@jancborchardt , we would appreciate your opinion here. This contribution updates the option 'Enable instant upload - Instantly upload photos...' to 'Enable instant upload - instantly upload media...' , affecting both photos and videos.

We think separate options for photos and videos would be better.

What do you think?

Member

davivel commented Apr 16, 2014

@jancborchardt , we would appreciate your opinion here. This contribution updates the option 'Enable instant upload - Instantly upload photos...' to 'Enable instant upload - instantly upload media...' , affecting both photos and videos.

We think separate options for photos and videos would be better.

What do you think?

@davivel

This comment has been minimized.

Show comment
Hide comment
@davivel

davivel Apr 16, 2014

Member

Sorry. We would appreciate opinions from everybody, of course. Just pinging @jancborchardt as our design expert.

Member

davivel commented Apr 16, 2014

Sorry. We would appreciate opinions from everybody, of course. Just pinging @jancborchardt as our design expert.

@enoch85

This comment has been minimized.

Show comment
Hide comment
@enoch85

enoch85 Apr 16, 2014

Member

I agree with you @davivel. The ability to choose instant uploads of either photos and/or videos would be best.

Also and option for both (separately) if you want to upload photos and/or videos through WIFI would be appreciated because maybe you want to upload photos through 3G/4G, but videos over WIFI or vice versa.

Member

enoch85 commented Apr 16, 2014

I agree with you @davivel. The ability to choose instant uploads of either photos and/or videos would be best.

Also and option for both (separately) if you want to upload photos and/or videos through WIFI would be appreciated because maybe you want to upload photos through 3G/4G, but videos over WIFI or vice versa.

@jancborchardt

This comment has been minimized.

Show comment
Hide comment
@jancborchardt

jancborchardt Apr 16, 2014

Member

Yup, also agree that photos and videos should be separate options. And both should have a sub-option if it should be uploaded on wifi only.

What are the current defaults? Both off, I presume.

Member

jancborchardt commented Apr 16, 2014

Yup, also agree that photos and videos should be separate options. And both should have a sub-option if it should be uploaded on wifi only.

What are the current defaults? Both off, I presume.

@davivel

This comment has been minimized.

Show comment
Hide comment
@davivel

davivel Apr 16, 2014

Member

Yes, both off. I'd say it's the right default, isn't it?

Member

davivel commented Apr 16, 2014

Yes, both off. I'd say it's the right default, isn't it?

@enoch85

This comment has been minimized.

Show comment
Hide comment
@enoch85

enoch85 Apr 16, 2014

Member

👍 @davivel @jancborchardt

I´m very exited about this! Expected release with 1.5.6?

Member

enoch85 commented Apr 16, 2014

👍 @davivel @jancborchardt

I´m very exited about this! Expected release with 1.5.6?

@davivel

This comment has been minimized.

Show comment
Hide comment
@davivel

davivel Apr 16, 2014

Member

Probably, if nothing strange happens. Stay tuned! :)

Member

davivel commented Apr 16, 2014

Probably, if nothing strange happens. Stay tuned! :)

@enoch85

This comment has been minimized.

Show comment
Hide comment
@enoch85

enoch85 Apr 16, 2014

Member

That´s just amazing news!

Member

enoch85 commented Apr 16, 2014

That´s just amazing news!

@jancborchardt

This comment has been minimized.

Show comment
Hide comment
@jancborchardt

jancborchardt Apr 16, 2014

Member

Yep, both off is the right default.

Member

jancborchardt commented Apr 16, 2014

Yep, both off is the right default.

javiergonzper added a commit that referenced this pull request Apr 22, 2014

Merge pull request #149 from owncloud/videoInstandUploads
Issue #136  [Feature] Instant upload of videos

@javiergonzper javiergonzper merged commit d60ddd8 into develop Apr 22, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@davivel davivel deleted the videoInstandUploads branch Apr 24, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment