Issue #136 [Feature] Instant upload of videos #149
Conversation
|
finally something worked ;-) |
|
I noticed that the included media player of owncloud ( not the android app) doesn't play mp4 videos. |
|
I included a check that Upload is only allowed when the app has a connection with wifi. Otherwise it would cost the user a lot of quota and he wouldn't recognize it because the upload will happen in the background. |
|
Better this waits a little. We have things to fix in the current instant upload of images before going with more instant uploads. |
|
@zerginator thanks for your work on this useful feature! Regarding only uploading using wifi, any chance that could be made a configuration option? It makes this feature not very useful for me. A very useful case for such a feature would be for protests/demonstrations where video evidence of the event is desired, but phones may be confiscated and video deleted. In those cases one rarely has access to wifi. |
|
+1 |
| @@ -156,10 +156,14 @@ | |||
|
|
|||
| <receiver android:name=".files.InstantUploadBroadcastReceiver"> | |||
| <intent-filter> | |||
| <action android:name="com.android.camera.NEW_PICTURE" /> | |||
| <action android:name="android.hardware.action.NEW_PICTURE" /> | |||
There was a problem hiding this comment.
This will break instant upload for older devices!
"android.hardware.action.NEW_PICTURE" was first introduced in API 14 --> refer to http://developer.android.com/reference/android/hardware/Camera.html
|
👍 please merge this soon |
|
Sorry, but we won't merge this until main problems with instant upload of images are fixed. That will be soon, fortunately. |
|
Some code (MediaService.java) depends of API level 17, so what's the big deal? |
|
@vip9 Not sure, but I am assuming you are referring to my comment. Every Android version from Android 2.2 is supported by the ownCloud app. More details: #110 (comment) |
|
As I see, the code in https://github.com/owncloud/android/blob/master/src/com/owncloud/android/media/MediaService.java#L160 refers to statics introduced in level 17 (e.g. MediaPlayer.MEDIA_ERROR_UNSUPPORTED) So what's the problem with using more code newer (same) as level 14? (It won't compile anyway) |
|
@vip9, the problem pointed by @LukeOwncloud is not adding a constant of API 17, but removing the old event. In the current version 1.4.5 both are used, each of them for different Android versions. Anyway, the reason why we don't want to add instant upload of videos by now is that instant upload of pictures needs to be fixed in several aspects. We don't want the same problems appear in the upload of videos, specially because they use to be bigger files. |
|
What’s the resolution on this? It has been 7 months, @davivel @masensio @rperezb @MTRichards we need to manage community contributions better. :) |
|
This will be merged into develop soon, maybe before the end of the year. |
|
@jancborchardt you are right, it is our goal for 2014 to manage better community contributions. As @davivel already said, this is on our top of the priorities. I would expect it before February :), December is a busy month |
|
Cool! :) |
|
@zerginator In these weeks we plan to merge your code about Instant Videos with develop. But the current version can't be merge automatically in develop. Could you please update this with the last changes? Thanks for your patience. |
|
Just a question. You talked about merging this in february, how is it going? When will this feature come to be realesed for real? |
|
It's not going too well. No idea when it will be released. My apologies. Not enough time to test everything. |
|
Now, this branch is updated with our develop branch. |
|
👍 i want this feature, and if possible an option to allow the user to pick between: Photo only, video only or both. |
|
@jancborchardt , we would appreciate your opinion here. This contribution updates the option 'Enable instant upload - Instantly upload photos...' to 'Enable instant upload - instantly upload media...' , affecting both photos and videos. We think separate options for photos and videos would be better. What do you think? |
|
Sorry. We would appreciate opinions from everybody, of course. Just pinging @jancborchardt as our design expert. |
|
I agree with you @davivel. The ability to choose instant uploads of either photos and/or videos would be best. Also and option for both (separately) if you want to upload photos and/or videos through WIFI would be appreciated because maybe you want to upload photos through 3G/4G, but videos over WIFI or vice versa. |
|
Yup, also agree that photos and videos should be separate options. And both should have a sub-option if it should be uploaded on wifi only. What are the current defaults? Both off, I presume. |
|
Yes, both off. I'd say it's the right default, isn't it? |
|
I´m very exited about this! Expected release with 1.5.6? |
|
Probably, if nothing strange happens. Stay tuned! :) |
|
That´s just amazing news! |
|
Yep, both off is the right default. |
| @@ -37,18 +37,21 @@ | |||
| import android.net.ConnectivityManager; | |||
| import android.net.NetworkInfo.State; | |||
| import android.preference.PreferenceManager; | |||
| import android.provider.MediaStore.Images.Media; | |||
| import android.provider.MediaStore.*; | |||
There was a problem hiding this comment.
You should import only the necessary clases in order to not import all that are under MediaStore
Issue #136 [Feature] Instant upload of videos
Use preemptive authentication except in server versions where it is n…
Issue #136 [Feature] Instant upload of videos