Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Show same remove dialog for every kind of file or folder #4404

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Aitorbp
Copy link
Contributor

@Aitorbp Aitorbp commented May 13, 2024

Related Issues

App: #4377

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@Aitorbp Aitorbp self-assigned this May 13, 2024
@Aitorbp Aitorbp force-pushed the feature/show_same_remove_dialog_for_every_file_folder branch from 6bef5ff to 98f3ddf Compare May 13, 2024 13:21
@Aitorbp Aitorbp linked an issue May 14, 2024 that may be closed by this pull request
8 tasks
@Aitorbp Aitorbp force-pushed the feature/show_same_remove_dialog_for_every_file_folder branch from 5f9c0e0 to 0b29948 Compare May 14, 2024 14:57
@Aitorbp Aitorbp requested a review from JuancaG05 May 14, 2024 16:17
Copy link
Collaborator

@joragua joragua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes here

@Aitorbp Aitorbp force-pushed the feature/show_same_remove_dialog_for_every_file_folder branch 4 times, most recently from 72c28ff to bf7df0e Compare June 4, 2024 07:25
@Aitorbp Aitorbp force-pushed the feature/show_same_remove_dialog_for_every_file_folder branch from d4c5d09 to f6c51c3 Compare June 14, 2024 13:54
@Aitorbp
Copy link
Contributor Author

Aitorbp commented Jun 17, 2024

Add new shortcut icon to remove dialog when shortcut pr will be merged.

Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several things to check here @Aitorbp

changelog/unreleased/4404 Outdated Show resolved Hide resolved
changelog/unreleased/4404 Outdated Show resolved Hide resolved
owncloudApp/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
owncloudApp/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
@Aitorbp Aitorbp force-pushed the feature/show_same_remove_dialog_for_every_file_folder branch 2 times, most recently from cb11037 to a9b7d13 Compare June 18, 2024 08:21
@Aitorbp Aitorbp requested a review from JuancaG05 June 18, 2024 08:46
changelog/unreleased/4404 Outdated Show resolved Hide resolved
changelog/unreleased/4404 Outdated Show resolved Hide resolved
owncloudApp/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
@Aitorbp Aitorbp force-pushed the feature/show_same_remove_dialog_for_every_file_folder branch from 8f01d7d to f2f8a83 Compare June 18, 2024 12:15
@Aitorbp Aitorbp requested a review from JuancaG05 June 18, 2024 12:20
@Aitorbp Aitorbp force-pushed the feature/show_same_remove_dialog_for_every_file_folder branch from 9c5e5bd to 9c525a2 Compare June 20, 2024 08:52
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, again, remove that new release note which shouldn't be here...

@Aitorbp Aitorbp requested a review from JuancaG05 June 20, 2024 11:50
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Show same remove dialog for every kind of file or folder
3 participants