-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE REQUEST] Show same remove dialog for every kind of file or folder #4404
base: master
Are you sure you want to change the base?
[FEATURE REQUEST] Show same remove dialog for every kind of file or folder #4404
Conversation
6bef5ff
to
98f3ddf
Compare
5f9c0e0
to
0b29948
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes here
...udApp/src/main/java/com/owncloud/android/presentation/files/filelist/MainFileListFragment.kt
Show resolved
Hide resolved
...rc/main/java/com/owncloud/android/presentation/files/removefile/RemoveFilesDialogFragment.kt
Show resolved
Hide resolved
72c28ff
to
bf7df0e
Compare
d4c5d09
to
f6c51c3
Compare
Add new shortcut icon to remove dialog when shortcut pr will be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several things to check here @Aitorbp
...rc/main/java/com/owncloud/android/presentation/files/removefile/RemoveFilesDialogFragment.kt
Outdated
Show resolved
Hide resolved
...rc/main/java/com/owncloud/android/presentation/files/removefile/RemoveFilesDialogFragment.kt
Outdated
Show resolved
Hide resolved
cb11037
to
a9b7d13
Compare
8f01d7d
to
f2f8a83
Compare
…ity to display thumbnails(img, mp4, folders...)
…se notes relate to this development
9c5e5bd
to
9c525a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, again, remove that new release note which shouldn't be here...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related Issues
App: #4377
ReleaseNotesViewModel.kt
creating a newReleaseNote()
with String resources (if required)QA