Provide space_ref to share requests when using spaces #10845

individual-it · 2023-04-26T08:58:26Z

Pre-submission Checks

I checked for similar issues, but could not find any. I also checked the closed issues. I could not contribute additional information to any existing issue.
I will take the time to fill in all the required fields. I know that the bug report may be dismissed otherwise due to lack of information.

Describe the bug

When clicking on "Create and copy public link to clipboard" from the context menu the user is lead to the webUI of ocis instead of a link being created.
This happens only after the first start of the client after connecting a new space, after a restart it works fine.

Expected behavior

I expect to get a public link in my clipboard

Steps to reproduce the issue

start ocis, in my case OCIS_URL=https://192.168.56.1:9200 ./ocis-3.0.0-rc.1-linux-amd64 server
connect the desktop client to ocis using the admin user
login to the webUI as admin
create a new space (in my case ict)
connect the new space to the desktop client
via webUI upload some files to the space
wait till the files are synced to the client
open the context menu of one of the files and select Create and copy public link to clipboard

=> browser opens and leads to the webUI

~~If the desktop client is restarted, the action works as intended~~

Screenshots

No response

Logs

ownCloud.log

Client version number

ownCloud 4.0.0.10732-rc1

Desktop environment (Linux only)

No response

Client package version and origin (Linux only)

No response

Installation path (Windows only)

c:\Program Files\ownCloud\

Server information

ocis 3.0.0-rc.1

Additional context

No response

The text was updated successfully, but these errors were encountered:

TheOneRing · 2023-04-26T09:16:31Z

Ocis responds with an error and we fallback to "displaying the share ui" which with ocis is the web.

23-04-26 11:14:15:331 [ info sync.httplogger ]:	"782f767f-b2e7-475f-941b-18c27969c9bd: Request: GET https://ocis.owncloud.test/ocs/v1.php/apps/files_sharing/api/v1/shares?path=%2FownCloud-4.0.0.10732-rc1.x64.msi&reshares=true&format=json Header: { OCS-APIREQUEST: true, Authorization: Bearer eyJhbGciOiJQUzI1NiIsImtpZCI6InByaXZhdGUta2V5IiwidHlwIjoiSldUIn0.eyJhdWQiOiJ4ZFhPdDEzSkt4eW0xQjFRY0VuY2YyWERrTEFleE1CRndpVDlqNkVmaGhIRkpoczJLTTlqYmpUbWY4SkJYRTY5IiwiZXhwIjoxNjgyNTAwNzA0LCJpYXQiOjE2ODI1MDA0MDQsImlzcyI6Imh0dHBzOi8vb2Npcy5vd25jbG91ZC50ZXN0IiwianRpIjoiZnowVWFzTXBHVVhhcmxPQnE5enZsZ0Uxb3NIWXFleDAiLCJsZy5pIjp7ImRuIjoiS2F0aGVyaW5lIEpvaG5zb24iLCJpZCI6InVpZD1rYXRoZXJpbmUsb3U9dXNlcnMsbz1saWJyZWdyYXBoLWlkbSIsInVuIjoia2F0aGVyaW5lIn0sImxnLnAiOiJpZGVudGlmaWVyLWxkYXAiLCJsZy50IjoiMSIsInNjcCI6Im9wZW5pZCBvZmZsaW5lX2FjY2VzcyBlbWFpbCBwcm9maWxlIiwic3ViIjoiQnpiXzY5Q1hUam9oR1JPTkBYaVlGZ2NITmR1dlFxejA1bXJOUllXdHRzNmJWYWRVM3U1bWZscTBxLUtQbzRRVmlTakJtNHYxeUlpcnE4dWJKNlVvZGdRIn0.BHD24pxAXZHvS6RlJTcP4kzM-vqSt0KWoL9oye9RbZGdzfcbXsTuOxGtLduGVARDwqb9-Qg1jw8IijJRBnG4iH_SnzQ2a4e5yXYo74XKKKXzsYvNYY-qbZu56bBGPT3Y3_2cbKFAQugKshtfdEzO76thRIIsIGGtnMY7f3OoHo2voTMZVwdHIQjM-foQt7UJPdLgHucEVSlCxEwZTtmxRWgrtlKfDL62n4ttRG_NEgn8FSJilSIIzUKyoAP7aphRQ4G1qshG1UQW2awlAx1ySPkOSefqMiSyQScyfOVwsoZ8s1cgS7XNHIuVPxtXOiczZapzOR4vlM5s0rqcztRgn0MR9Y-G-TYYok6iigiE_o5KoGEVb8LemA7y0rE3ka3tDz3YmG0CGuVcwUZywnS2lE3UZ60bBkNCbon0GL8PJSzd1tg9lPRmNcBQXqbC0NvqRwYHm1OlIwq-uaSnXGa3ULXANHI0JDq1wWhjzy7tKAkhmkMHAR5oVjaNQcM-6pw6OQ3lf7YRsZp2r6kCElsHaLI1jfvt0DeZnKDt8DXwwocQZzk5EjOOoHVbvM6-PsW42UTq1GOfpP-noR-wqNz9XOokjPMOOB9s8bC4TRaDzTk4ZTVsZd94wdmwiHUfuWCDA3XOyTdgWGd8bOR6ctE0ExYI_N1WWLJvqySVCSVf6b8, User-Agent: Mozilla/5.0 (Windows) mirall/4.0.0-git (ownCloud, windows-10.0.22621 ClientArchitecture: x86_64 OsArchitecture: x86_64), Accept: */*, X-Request-ID: 782f767f-b2e7-475f-941b-18c27969c9bd, Original-Request-ID: 782f767f-b2e7-475f-941b-18c27969c9bd, } Data: []"
23-04-26 11:14:15:350 [ info sync.httplogger ]:	"782f767f-b2e7-475f-941b-18c27969c9bd: Response: GET 200 (19ms) https://ocis.owncloud.test/ocs/v1.php/apps/files_sharing/api/v1/shares?path=%2FownCloud-4.0.0.10732-rc1.x64.msi&reshares=true&format=json Header: { Content-Length: 74, Content-Type:

individual-it · 2023-04-26T09:56:01Z

On the same space, some files work others not.
In this log. 01.jpg refers to the webUI, but 04.jpg generates a link
ownCloud.log

TheOneRing · 2023-04-26T10:03:36Z

@wkloucek or @micbar can we have a look together?

micbar · 2023-04-26T10:37:46Z

Ocis responds with an error and we fallback to "displaying the share ui" which with ocis is the web.

Where is the error?

TheOneRing · 2023-04-26T11:38:28Z

Ocis responds with an error and we fallback to "displaying the share ui" which with ocis is the web.

Where is the error?

"5980b257-3fb9-4a4d-86b4-23a1edc0360e", X-Request-ID: "5980b257-3fb9-4a4d-86b4-23a1edc0360e") for OCC::ShareManager(0x18e32a554b0)
23-04-26 02:53:13:612 [ info sync.httplogger ]:	"5980b257-3fb9-4a4d-86b4-23a1edc0360e:
Response: GET 200 (11ms) https://192.168.56.1:9200/ocs/v1.php/apps/files_sharing/api/v1/shares?path=%2F01.jpg&reshares=true&format=json
Header: { Content-Length: 74, Content-Type: application/json; charset=utf-8, Date: Wed, 26 Apr 2023 09:53:16 GMT, Ocs-Api-Version: 1, Vary: Origin, }
Data: [{\"ocs\":{\"meta\":{\"status\":\"error\",\"statuscode\":998,\"message\":\"not found\"}}}]"
23-04-26 02:53:13:612 [ warning gui.socketapi.publiclink ]:	Share fetch/create error 998 "not found"

michaelstingl · 2023-05-02T12:16:29Z

@individual-it @ScharfViktor please re-test with the oCIS 3.0-rc2 later today. (rc1 had a caching issue)

individual-it · 2023-05-04T09:17:38Z

retried with ocis 3.0 rc2 and client 4.0 rc2 and the issue persists
ownCloud.zip

butonic · 2023-05-09T20:03:33Z

We noticed that using the path parameter is very slow, because oCIS then has to discover the space that is responsible for the path.

I only see /01.jpg in the request but how should the server know which space is meant? Web now uses a space_ref to exactly identify the resource.

I'll take another look Tomorrow...

butonic · 2023-05-11T15:41:15Z

This is definitely a missing space form value in the request. The easiest is to just take the oc:fileid from a propfind and send it as the space form value instead of a path. They can be combined, clients can use the space root id as space and a path relative to the space root. Technically path is always relative to space. and if space is unset the users home is assumed. That is why it works for personal spaces.

michaelstingl · 2023-05-11T15:55:40Z

@butonic how can clients know? oCIS announces oC10-style public links in /ocs/v1.php/cloud/capabilities?format=json

                    "public": {
                        "enabled": true,
                        "send_mail": true,
                        "social_share": true,
                        "upload": true,
                        "multiple": true,
                        "supports_upload_only": true,
                        "password": {
                            "enforced_for": {
                                "read_only": false,
                                "read_write": false,
                                "read_write_delete": false,
                                "upload_only": false
                            },
                            "enforced": false
                        },
                        "expire_date": {
                            "enabled": false
                        },
                        "can_edit": true,
                        "alias": true
                    },

butonic · 2023-05-12T05:44:17Z

Well, how do they detect that spaces are available? Space support makes it necessary to send a space in addition to the path so the server knows which space the path belongs to.

micbar · 2023-05-15T09:19:49Z

Conclusion: not a blocker because the user experience does not break.

Opening the WebUI is a good fallback.

To achieve creating a public link on the client side would need client side changes.

micbar · 2023-05-15T09:20:28Z

@michaelstingl Can you transfer the issue to the client repo?

micbar · 2023-05-15T09:21:06Z

Addition: needs to be documented -> Server Team
Other clients need to be checked.

michaelstingl · 2023-05-25T09:44:50Z

@TheOneRing @fmoc so, we'll send the space_ref when "public": { "enabled": true, AND /graph/v1.0/me/drives is present?

TheOneRing · 2023-07-06T12:18:27Z

To check for spaces support:

client/src/gui/accountstate.cpp

Line 552 in e4ae053

bool AccountState::supportsSpaces() const

erikjv · 2023-07-11T15:25:39Z

When I send a get request with the space_ref set, I get no data in response:

23-07-11 17:22:32:094 [ info sync.httplogger ]:	"6d9efed9-c01b-4154-bf7f-8d406183fd30: Request: GET https://ocis.owncloud.com/ocs/v1.php/apps/files_sharing/api/v1/shares?path=%2FREADME.md&reshares=true&space_ref=166d1210-cdb9-50ab-9f1e-ecb9ef12a304%24f89c99f6-281d-4b81-8d56-10d2ed14f612&format=json Header: { OCS-APIREQUEST
: true, Authorization: Bearer [redacted], User-Agent: Mozilla/5.0 (Macintosh) mirall/5.0.0-git (ownCloud, macos-21.6.0 ClientArchitecture: x86_64 OsArchitecture: x86_64), Accept: */*, Accept-Language: en_DE, X-Request-ID: 6d9efed9-c01b-4154-bf7f-8d406183fd30, Original-Request-ID: 6d9efed9-c01b-4154-bf7f-8d406183fd30, } Data: []"
23-07-11 17:22:32:149 [ info sync.httplogger ]:	"6d9efed9-c01b-4154-bf7f-8d406183fd30: Response: GET 200 (54ms) https://ocis.owncloud.com/ocs/v1.php/apps/files_sharing/api/v1/shares?path=%2FREADME.md&reshares=true&space_ref=166d1210-cdb9-50ab-9f1e-ecb9ef12a304%24f89c99f6-281d-4b81-8d56-10d2ed14f612&format=json Header: { Content-Length: 74, Content-Type: application/json; charset=utf-8, Date: Tue, 11 Jul 2023 15:22:32 GMT, Ocs-Api-Version: 1, Referrer-Policy: strict-origin-when-cross-origin, Strict-Transport-Security: max-age=315360000; preload, Vary: Origin, X-Content-Type-Options: nosniff, X-Frame-Options: SAMEORIGIN, X-Xss-Protection: 0, } Data: [{\"ocs\":{\"meta\":{\"status\":\"ok
\",\"statuscode\":100,\"message\":\"OK\"},\"data\":[]}}]"

Note: I created a new space called "New space", and put a file "README.md" in it.

TheOneRing · 2023-07-11T15:50:21Z

api/v1/shares

Oh the old code performs two requests, it lists the existing shares and creates a new one if it didn't exist.
So we only did the listing.

erikjv · 2023-07-12T13:10:33Z

Oh the old code performs two requests, it lists the existing shares and creates a new one if it didn't exist.
So we only did the listing.

Can you point out where the two requests are made in the old code?

TheOneRing · 2023-07-13T04:26:43Z

(

client/src/gui/socketapi/socketapi.cpp

Line 615 in 92f5d98

AccountPtr account = fileData.folder->accountState()->account();

client/src/gui/socketapi/socketapi.cpp

Line 570 in 92f5d98

_shareManager.createLinkShare(_serverPath, shareName, noPassword, expireDate);

Please don't use the deprecated ShareManager

Fixes: #10845

TheOneRing · 2023-07-28T15:32:23Z

This is definitely a missing space form value in the request. The easiest is to just take the oc:fileid from a propfind and send it as the space form value instead of a path. They can be combined, clients can use the space root id as space and a path relative to the space root. Technically path is always relative to space. and if space is unset the users home is assumed. That is why it works for personal spaces.

Could you please provide an example query?
I've seen different parameter names and argument definitions discussed in this issue and am lost now.

fmoc · 2023-08-01T13:45:30Z

@micbar ^

michaelstingl · 2023-08-02T08:25:35Z

What we did before:

23-08-02 10:09:46:707 [ info sync.httplogger ]:	"0e177d5a-8e16-4b80-a09a-d69dc4a14460:
Request: GET https://ocis.ocis-traefik.daily.owncloud.works/ocs/v1.php/apps/files_sharing/api/v1/shares?path=%2FHacker-Songs&reshares=true&format=json
Header: { OCS-APIREQUEST: true, Authorization: Bearer [redacted], User-Agent: Mozilla/5.0 (Macintosh) mirall/5.0.0.11632-daily20230802 (testpilotcloud, macos-22.6.0 ClientArchitecture: arm64 OsArchitecture: arm64), Accept: */*, Accept-Language: en_DE, X-Request-ID: 0e177d5a-8e16-4b80-a09a-d69dc4a14460, Original-Request-ID: 0e177d5a-8e16-4b80-a09a-d69dc4a14460, }
Data: []"

23-08-02 10:09:46:760 [ info sync.httplogger ]:	"0e177d5a-8e16-4b80-a09a-d69dc4a14460:
Response: GET 200 (52ms) https://ocis.ocis-traefik.daily.owncloud.works/ocs/v1.php/apps/files_sharing/api/v1/shares?path=%2FHacker-Songs&reshares=true&format=json
Header: { Content-Length: 74, Content-Type: application/json; charset=utf-8, Date: Wed, 02 Aug 2023 08:09:46 GMT, Ocs-Api-Version: 1, Vary: Origin, X-Request-Id: 0e177d5a-8e16-4b80-a09a-d69dc4a14460, }
Data: [{\"ocs\":{\"meta\":{\"status\":\"error\",\"statuscode\":998,\"message\":\"not found\"}}}]"

Now, we ask for existing Shares, and the response look sane:

23-07-28 16:52:19:340 [ info sync.httplogger ]:	"b642efc9-75f2-4e8f-9e7e-7cd17f2b2e90: 
Request: GET https://ocis.owncloud.com/ocs/v1.php/apps/files_sharing/api/v1/shares?path=%2Funtitled folder%2Fasdf.txt&reshares=true&space_ref=166d1210-cdb9-50ab-9f1e-ecb9ef12a304%24534bb038-6f9d-4093-946f-133be61fa4e7&format=json 
Header: { OCS-API
REQUEST: true, Authorization: Bearer [redacted], User-Agent: Mozilla/5.0 (Macintosh) mirall/5.0.0-git (ownCloud, macos-21.6.0 ClientArchitecture: x86_64 OsArchitecture: x86_64), Accept: */*, Accept-Language: en_DE, X-Request-ID: b642efc9-75f2-4e8f-9e7e-7cd17f2b2e90, Original-Request-ID: b642efc9-75f2-4e8f-9e7e-7cd17f2b2e90, } 
Data: []"

23-07-28 16:52:19:387 [ info sync.httplogger ]:	"b642efc9-75f2-4e8f-9e7e-7cd17f2b2e90: 
Response: GET 200 (46ms) https://ocis.owncloud.com/ocs/v1.php/apps/files_sharing/api/v1/shares?path=%2Funtitled folder%2Fasdf.txt&reshares=true&space_ref=166d1210-cdb9-50ab-9f1e-ecb9ef12a304%24534bb038-6f9d-4093-946f-133be61fa4e7&format=json 
Header: { Content-Length: 74, Content-Type: application/json; charset=utf-8, Date: Fri, 28 Jul 2023 14:52:19 GMT, Ocs-Api-Version: 1, Referrer-Policy: strict-origin-when-cross-origin, Strict-Transport-Security: max-age=315360000; preload, Vary: Origin, X-Content-Type-Options: nosniff, X-Frame-Options: SAMEORIGIN, X-Xss-Protection: 0, } 
Data: [{\"ocs\":{\"meta\":{\"status\":\"ok\",\"statuscode\":100,\"message\":\"OK\"},\"data\":[]}}]"

(no existing share ✅ )

michaelstingl · 2023-08-02T08:28:39Z

The easiest is to just take the oc:fileid from a propfind and send it as the space form value instead of a path. They can be combined, clients can use the space root id as space and a path relative to the space root. Technically path is always relative to space. and if space is unset the users home is assumed. That is why it works for personal spaces.

Creating the Share with space_ref added also fails:

Data: [
path=%2Funtitled%20folder%2Fasdf.txt
&shareType=3
&name=Context%20menu%20share
&space_ref=166d1210-cdb9-50ab-9f1e-ecb9ef12a304%24534bb038-6f9d-4093-946f-133be61fa4e7
]"

@micbar @butonic how should the request look like? Link to docs?

Full HTTP:

23-07-28 16:52:19:389 [ info sync.httplogger ]:	"64ba3a19-eb98-40f7-8344-7ddfe39eb42e: 
Request: POST https://ocis.owncloud.com/ocs/v1.php/apps/files_sharing/api/v1/shares?format=json 
Header: { Content-Type: application/x-www-form-urlencoded; charset=UTF-8, OCS-API
REQUEST: true, Authorization: Bearer [redacted], User-Agent: Mozilla/5.0 (Macintosh) mirall/5.0.0-git (ownCloud, macos-21.6.0 ClientArchitecture: x86_64 OsArchitecture: x86_64), Accept: */*, Accept-Language: en_DE, X-Request-ID: 64ba3a19-eb98-40f7-8344-7ddfe39eb42e, Original-Request-ID: 64ba3a19-eb98-40f7-8344-7ddfe39eb42e, Content-Length: 162, } 
Data: [path=%2Funtitled%20folder%2Fasdf.txt&shareType=3&name=Context%20menu%20share&space_ref=166d1210-cdb9-50ab-9f1e-ecb9ef12a304%24534bb038-6f9d-4093-946f-133be61fa4e7]"

23-07-28 16:52:19:419 [ info sync.httplogger ]:	"64ba3a19-eb98-40f7-8344-7ddfe39eb42e: 
Response: POST 200 (29ms) https://ocis.owncloud.com/ocs/v1.php/apps/files_sharing/api/v1/shares?format=json 
Header: { Content-Length: 89, Content-Type: application/json; charset=utf-8, Date: Fri, 28 Jul 2023 14:52:19 GMT, Ocs-Api-Version: 1, Referrer-Policy: strict-origin-when-cross-origin, Strict-Transport-Security: max-age=315360000; preload, Vary: Origin, X-Content-Type-Options: nosniff, X-Frame-Options: SAMEORIGIN, X-Xss-Protection: 0, } 
Data: [{\"ocs\":{\"meta\":{\"status\":\"error\",\"statuscode\":400,\"message\":\"Can not share space root\"}}}]"

michaelstingl · 2023-08-02T08:34:01Z

Web does this:

--data '
shareType=3
&path=%2FHacker-Songs
&space_ref=e51de7b9-c2c2-4719-ac38-1d933cf03e67%24c4f11913-eaa6-4c7d-bb60-ce5cf8d25b38!428f6a92-486a-4f65-9252-e32216e0509c
&permissions=1
&name=Link
&quicklink=true
&attributes%5B0%5D%5Bkey%5D=isQuickLink
&attributes%5B0%5D%5Bscope%5D=files_sharing
&attributes%5B0%5D%5Bvalue%5D=true'

Copy as cURL from Web Inspector:

curl 'https://ocis.ocis-traefik.daily.owncloud.works/ocs/v1.php/apps/files_sharing/api/v1/shares' \
-X 'POST' \
-H 'Content-Type: application/x-www-form-urlencoded' \
-H 'Authorization: Bearer eyJhbGciOiJQUzI1NiIsImtpZCI6InByaXZhdGUta2V5IiwidHlwIjoiSldUIn0.eyJhdWQiOiJ3ZWIiLCJleHAiOjE2OTA5NjUwMjcsImlhdCI6MTY5MDk2NDcyNywiaXNzIjoiaHR0cHM6Ly9vY2lzLm9jaXMtdHJhZWZpay5kYWlseS5vd25jbG91ZC53b3JrcyIsImp0aSI6ImZGNENENzc4SktWOFR4ZmdtU1l6TGxyX3dXTHBEdENHIiwibGcuaSI6eyJkbiI6IkthdGhlcmluZSBKb2huc29uIiwiaWQiOiJvd25DbG91ZFVVSUQ9NTM0YmIwMzgtNmY5ZC00MDkzLTk0NmYtMTMzYmU2MWZhNGU3IiwidW4iOiJrYXRoZXJpbmUifSwibGcucCI6ImlkZW50aWZpZXItbGRhcCIsImxnLnQiOiIxIiwic2NwIjoib3BlbmlkIHByb2ZpbGUgZW1haWwiLCJzdWIiOiJlcHZEcFBoN2tuTl9MeUk2QG1MSzVzU3FVYWVfVjAzbVNPa0ZCS1NkbUs2REx6THJacVNESVpIWXRqb0ZpdEJOcTV0aTNtN19YTUxIekhVbGpXNUx4Z3cifQ.THeMqHglbc241cPJ2BKpdHDf0bLkXfvOP3RirCHqD9Kd4FMGfNaXAWNNsAcbIuKIglEe94xgmct2vxdrqu1LbJ-8XCswgecYbGCH29h6bfBC7Zw2QVUGrfXZiB68yYE4HozmEIuq9KNsv2HcjbAiwYI3hnkTKBC7mVc_SwQ2Yfj8zUVq5I_lSW2zqsg5LAa8DLWKbya0cr5IPKfReq1PoyVAmtXX6VX2XWDDxUXTnZvDUNLowd4stUU5XKCkYIbusmCZUfDFX55fUQrcapQsMYqp7EuULBrBcC2qQTaJECW2VaRZdMp5O9_wr95xOnIcFsAMTS6WOtIvwcxFjF2Btygb6LvR7xmzOyIucAuue6vZ3VKE-4gaFxI0vLl5RR3ypPTKmBGkitQQ4o3meB1tS8KxtpRmXo1Eg81VAILIADStG9eYajcpa_xqe7iJMA8bSFPGWA4zOaA7sY5ur7srkNAgXNxKmhOScDwMiy1Wf56XFDUXm2F7XmNa1frpp0LgB0HcqNE8NDFoKGJQ2e29SGKV18IT_-Th6hva6HvyWOfDhDKFV0sA7IXV-U4afDymaoEQZsh7OlMHEnTKA2o4lv8ceYqFDbzt6UE6A3jz7Hadn6-BJUMHuC8pLjiWhsvMDtE1gB07rAQZJaiMOo7NBWU7-R-5MYOVFfR91HQWy6c' \
-H 'Accept: */*' \
-H 'Sec-Fetch-Site: same-origin' \
-H 'Accept-Language: en' \
-H 'Accept-Encoding: gzip, deflate, br' \
-H 'Sec-Fetch-Mode: cors' \
-H 'Origin: https://ocis.ocis-traefik.daily.owncloud.works' \
-H 'Referer: https://ocis.ocis-traefik.daily.owncloud.works/files/spaces/project/ict?fileId=e51de7b9-c2c2-4719-ac38-1d933cf03e67%24c4f11913-eaa6-4c7d-bb60-ce5cf8d25b38%21c4f11913-eaa6-4c7d-bb60-ce5cf8d25b38&items-per-page=100&files-spaces-generic-view-mode=resource-table&tiles-size=1&sort-by=name&sort-dir=asc' \
-H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.6 Safari/605.1.15' \
-H 'Content-Length: 310' \
-H 'Connection: keep-alive' \
-H 'Host: ocis.ocis-traefik.daily.owncloud.works' \
-H 'Sec-Fetch-Dest: empty' \
-H 'ocs-apirequest: true' \
-H 'x-requested-with: XMLHttpRequest' \
-H 'x-request-id: d52b2d98-565c-4149-8933-4a77761eb7b5' \
--data 'shareType=3&path=%2FHacker-Songs&space_ref=e51de7b9-c2c2-4719-ac38-1d933cf03e67%24c4f11913-eaa6-4c7d-bb60-ce5cf8d25b38!428f6a92-486a-4f65-9252-e32216e0509c&permissions=1&name=Link&quicklink=true&attributes%5B0%5D%5Bkey%5D=isQuickLink&attributes%5B0%5D%5Bscope%5D=files_sharing&attributes%5B0%5D%5Bvalue%5D=true'

Tested with:

[Log]  ownCloud Web UI 7.1.0-rc.4  (index.html-25ddd689.mjs, line 7)
[Log]  Infinite Scale 3.1.0-beta.1+d65476ff0 Community  (index.html-25ddd689.mjs, line 7)

michaelstingl · 2023-08-02T08:36:18Z

@micbar @butonic space_ref deprecated 1y ago?

Deprecate space_ref, use space instead cs3org/reva#2913

michaelstingl · 2023-08-02T08:43:39Z

Seems space parameter also didn't work?

POST response does not return correct path when creating public link ocis#5139 (comment)

-data-binary '
path=/A/land2.jpg
&shareType=3
&permissions=1
&name=link1
&space=52c34980-e15f-49bf-a47f-c151c7d6ec9a$d45835cb-8606-4075-9488-076d315119f5
' | json_pp

What exactly does cs3org/reva#4004 fix?

micbar · 2023-08-02T09:41:15Z

Conclusion

space and space_ref are currently treated equal.

oc10 compatibility

The path parameter is there to stay compatible with oc10
It can be used by clients which know "nothing about spaces"

ocis (bad ocs API experience, will be replaced by graph ASAP)

On the backend, we identify resources by a Reference (https://cs3org.github.io/cs3apis/#cs3.storage.provider.v1beta1.Reference)

Easiest solution

Use the id of the target resource and no path

So the easiest way to go, is to use the OC-FileID from WebDAV and no path.

Optional

Like in the mentioned CS3 Api docs, you could also use the id and a relative path.
The combination needs to be a valid resource, which means the id needs to point to a resource which is in the correct relative location to the path.

michaelstingl · 2023-08-02T10:29:20Z

@micbar thanks for the recommendation. I'll coordinate across clients.

Desktop client team decided to kill the /ocs/ for accounts setup with /graph/v1.0/me/drives , and they'll build a shiny future based on a new API.

TheOneRing · 2023-08-02T11:04:40Z

@erikjv please disable the context menu entry if account->supportsSpaces is true.

fmoc · 2023-08-04T11:41:17Z

Resolved by and tested in #11079.

ScharfViktor mentioned this issue Apr 27, 2023

Release 3.0.0 RC1 owncloud/ocis#6105

Closed

89 tasks

HanaGemela mentioned this issue May 2, 2023

Release 4.0.0 #10628

Closed

51 tasks

ScharfViktor mentioned this issue May 4, 2023

Release 3.0.0 RC4, RC5 and final owncloud/ocis#6230

Closed

86 tasks

TheOneRing changed the title ~~"create and copy public link" leads to webUI for newly connected spaces~~ "create and copy public link" results in server error 998 May 9, 2023

micbar assigned butonic May 9, 2023

michaelstingl transferred this issue from owncloud/client May 9, 2023

butonic removed their assignment May 15, 2023

TheOneRing transferred this issue from owncloud/ocis May 16, 2023

TheOneRing changed the title ~~"create and copy public link" results in server error 998~~ Provide space_ref to share requests when using spaces May 16, 2023

TheOneRing added the p2-high Escalation, on top of current planning, release blocker label May 16, 2023

TheOneRing added this to the Desktop Client 5.0 milestone May 16, 2023

TheOneRing assigned fmoc May 16, 2023

fmoc assigned erikjv and unassigned fmoc Jun 16, 2023

erikjv added a commit that referenced this issue Jul 28, 2023

Add space reference to public link

4a3b734

Fixes: #10845

erikjv mentioned this issue Jul 28, 2023

Add space reference to public link #11073

Closed

fmoc closed this as completed Aug 4, 2023

github-project-automation bot moved this from Prio 3 or less to Done in Infinite Scale Team Board Aug 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Provide space_ref to share requests when using spaces #10845

Provide space_ref to share requests when using spaces #10845

individual-it commented Apr 26, 2023 •

edited

Loading

TheOneRing commented Apr 26, 2023

individual-it commented Apr 26, 2023

TheOneRing commented Apr 26, 2023

micbar commented Apr 26, 2023

TheOneRing commented Apr 26, 2023 •

edited by michaelstingl

Loading

michaelstingl commented May 2, 2023

individual-it commented May 4, 2023

butonic commented May 9, 2023

butonic commented May 11, 2023

michaelstingl commented May 11, 2023

butonic commented May 12, 2023

micbar commented May 15, 2023

micbar commented May 15, 2023

micbar commented May 15, 2023

michaelstingl commented May 25, 2023

TheOneRing commented Jul 6, 2023

erikjv commented Jul 11, 2023

TheOneRing commented Jul 11, 2023

erikjv commented Jul 12, 2023

TheOneRing commented Jul 13, 2023 •

edited

Loading

TheOneRing commented Jul 28, 2023

fmoc commented Aug 1, 2023

michaelstingl commented Aug 2, 2023

michaelstingl commented Aug 2, 2023 •

edited

Loading

michaelstingl commented Aug 2, 2023

michaelstingl commented Aug 2, 2023 •

edited

Loading

michaelstingl commented Aug 2, 2023 •

edited

Loading

micbar commented Aug 2, 2023

michaelstingl commented Aug 2, 2023 •

edited

Loading

TheOneRing commented Aug 2, 2023

fmoc commented Aug 4, 2023

Provide space_ref to share requests when using spaces #10845

Provide space_ref to share requests when using spaces #10845

Comments

individual-it commented Apr 26, 2023 • edited Loading

Pre-submission Checks

Describe the bug

Expected behavior

Steps to reproduce the issue

Screenshots

Logs

Client version number

Desktop environment (Linux only)

Client package version and origin (Linux only)

Installation path (Windows only)

Server information

Additional context

TheOneRing commented Apr 26, 2023

individual-it commented Apr 26, 2023

TheOneRing commented Apr 26, 2023

micbar commented Apr 26, 2023

TheOneRing commented Apr 26, 2023 • edited by michaelstingl Loading

michaelstingl commented May 2, 2023

individual-it commented May 4, 2023

butonic commented May 9, 2023

butonic commented May 11, 2023

michaelstingl commented May 11, 2023

butonic commented May 12, 2023

micbar commented May 15, 2023

micbar commented May 15, 2023

micbar commented May 15, 2023

michaelstingl commented May 25, 2023

TheOneRing commented Jul 6, 2023

erikjv commented Jul 11, 2023

TheOneRing commented Jul 11, 2023

erikjv commented Jul 12, 2023

TheOneRing commented Jul 13, 2023 • edited Loading

TheOneRing commented Jul 28, 2023

fmoc commented Aug 1, 2023

michaelstingl commented Aug 2, 2023

michaelstingl commented Aug 2, 2023 • edited Loading

michaelstingl commented Aug 2, 2023

michaelstingl commented Aug 2, 2023 • edited Loading

michaelstingl commented Aug 2, 2023 • edited Loading

micbar commented Aug 2, 2023

Conclusion

oc10 compatibility

ocis (bad ocs API experience, will be replaced by graph ASAP)

Easiest solution

Optional

michaelstingl commented Aug 2, 2023 • edited Loading

TheOneRing commented Aug 2, 2023

fmoc commented Aug 4, 2023

individual-it commented Apr 26, 2023 •

edited

Loading

TheOneRing commented Apr 26, 2023 •

edited by michaelstingl

Loading

TheOneRing commented Jul 13, 2023 •

edited

Loading

michaelstingl commented Aug 2, 2023 •

edited

Loading

michaelstingl commented Aug 2, 2023 •

edited

Loading

michaelstingl commented Aug 2, 2023 •

edited

Loading

michaelstingl commented Aug 2, 2023 •

edited

Loading