Retina/HiRes icon support #11

LukasReschke · 2012-10-23T08:38:41Z

Currently the ownCloud icon looks pixelated under OS X with a retina MBP.
It might be a good idea to have a retina ready icon in the menu bar and the about section.

danimo · 2012-10-23T08:40:53Z

This needs Qt support from upstream.

danimo · 2012-10-23T09:58:53Z

https://codereview.qt-project.org/#change,33266 is the change we need to track.

jancborchardt · 2013-04-30T17:46:55Z

@danimo the upstream issue you referred is marked as »Abandoned«. But the same author made a new one which is merged: https://codereview.qt-project.org/#change,49767

Does that set the base for using retina icons?

danimo · 2014-04-07T09:05:33Z

@jancborchardt I'd need the following icons in hidpi (@2x), so basically twice the size:

resources/activity.png
resources/dialog-cancel.png
resources/dialog-close.png
resources/dialog-ok.png
resources/folder-grey.png
resources/folder-remote-32.png
resources/folder-remote.png
resources/folder-sync.png
resources/lock-http.png
resources/lock-https.png
resources/network.png
resources/owncloud_logo_blue.png
resources/settings.png
resources/task-ongoing.png
resources/view-refresh.png
resources/warning-16.png

ladrua · 2014-09-10T20:13:47Z

So I can just add state-ok-32@2x.png file to my theme icons? so retina would be 64x64?

LukasReschke · 2014-10-09T12:20:43Z

@jancborchardt Do you have those icons in double size somewhere? - It's somewhat annoying to have everything in ownCloud Retina ready except our native application ;-)

LukasReschke · 2014-10-09T12:21:43Z

jancborchardt · 2014-10-10T10:36:36Z

Right – I just mailed Achim about it. He made the icons for the desktop client.

jancborchardt · 2014-10-21T14:00:23Z

@danimo @dragotin did you see Achim’s reply with the icons?

mcmanimie · 2014-11-26T17:01:20Z

Will the retina icons be included in the next release?

danimo · 2015-02-12T18:45:54Z

Can be tested through https://download.owncloud.com/desktop/daily/ownCloud-1.8.0.2011-nightly20150212.pkg.

@LukasReschke Interested? :)

LukasReschke · 2015-02-12T19:09:45Z

🚀

danimo · 2015-02-12T19:11:21Z

Try now :)

LukasReschke · 2015-02-12T19:29:52Z

🚀 Looks totally awesome 🚀

Thanks!!!

danimo · 2015-02-12T23:18:22Z

@lmaestro Do you have a retina mac avail?

jancborchardt · 2015-02-13T14:52:17Z

@danimo the proper retina icons for the settings dialog and for the lock icon are now also available – check the desktop-homies share. ;) (Please add the SVG sources in the repo! All files are compressed.)

dragotin · 2015-02-13T16:29:32Z

@LukasReschke screenshot - or it does not exist ;-)

LukasReschke · 2015-02-13T18:44:45Z

pulse00 · 2015-02-13T20:12:53Z

looks great, thanks!

jancborchardt · 2015-02-16T12:59:02Z

It looks great and I think the activity icon is very fitting. If anything, the icons for »General« and »Network« look a bit out of place. (Pale color on Network in comparison to Account.)

danimo · 2015-02-16T13:00:04Z

@jancborchardt Talk to Cuppertino. Those are their recommended icons :)

jancborchardt · 2015-02-16T23:15:33Z

Haha, ok. So I would say we close the case cause the new icons I gave you are retina and look better than the KDE-like icon set? ;)

The Qt HTTP thread calls authenticationRequired (indirectly) using a BlockingQueuedConnection. So when we call invalidateToken from slot connected to this signal and end up calling QNAM::clearAccessCache which waits on the thread for 5 seconds Backtraces: Qt HTTP thread: #0 0x00007ffff20c707f in pthread_cond_wait@@GLIBC_2.3.2 () #1 0x00007ffff43f0c0b in QWaitConditionPrivate::wait #2 QWaitCondition::wait #3 0x00007ffff43ea06b in QSemaphore::acquire #4 0x00007ffff45dcf6f in QMetaObject::activate [...] #9 0x00007ffff45dd607 in QMetaObject::activate #10 0x00007ffff4edbaf7 in QHttpNetworkReply::authenticationRequired #11 0x00007ffff4e0b2b4 in QHttpNetworkConnectionPrivate::handleAuthenticateChallenge #12 0x00007ffff4e10753 in QHttpNetworkConnectionChannel::handleStatus #13 0x00007ffff4e11cc9 in QHttpNetworkConnectionChannel::allDone #14 0x00007ffff4e14605 in QHttpProtocolHandler::_q_receiveReply Main Thread: #0 0x00007ffff20c7428 in pthread_cond_timedwait@@GLIBC_2.3.2 () #1 0x00007ffff43f0b56 in QWaitConditionPrivate::wait_relative (time=5000, this=0x136c580) #2 QWaitConditionPrivate::wait (time=5000, this=0x136c580) #3 QWaitCondition::wait (this=this@entry=0x136c788, mutex=mutex@entry=0x136c760, time=time@entry=5000) #4 0x00007ffff43efa6e in QThread::wait (this=<optimized out>, time=time@entry=5000) #5 0x00007ffff4e1edd3 in QNetworkAccessManagerPrivate::clearCache #6 0x00007ffff7b6fb03 in OCC::HttpCredentials::invalidateToken() #7 0x000000000057adb4 in OCC::AccountState::slotInvalidCredentials() #8 0x000000000057ac76 in OCC::AccountState::slotConnectionValidatorResult(OCC::ConnectionValidator::Status, QStringList const&) () #9 0x00000000005ab45c in OCC::AccountState::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) #10 0x00007ffff45dcd30 in QMetaObject::activate #11 0x00007ffff7b78671 in OCC::ConnectionValidator::connectionResult(OCC::ConnectionValidator::Status, QStringList) () #12 0x00007ffff7ae2514 in OCC::ConnectionValidator::reportResult(OCC::ConnectionValidator::Status) () #13 0x00007ffff7ae39b7 in OCC::ConnectionValidator::slotAuthFailed(QNetworkReply*) () #14 0x00007ffff7b784a9 in OCC::ConnectionValidator::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) () #15 0x00007ffff45dcd30 in QMetaObject::activate #16 0x00007ffff7b766dc in OCC::AbstractNetworkJob::networkError(QNetworkReply*) #17 0x00007ffff7af9f6e in OCC::AbstractNetworkJob::slotFinished() #18 0x00007ffff7b7654d in OCC::AbstractNetworkJob::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) () #20 0x00007ffff45dd607 in QMetaObject::activate #21 0x00007ffff4edd143 in QNetworkReply::finished #22 0x00007ffff4e3fec7 in QNetworkReplyHttpImplPrivate::finished #23 0x00007ffff4e41818 in QNetworkReplyHttpImpl::close #24 0x00007ffff7b7047b in OCC::HttpCredentials::slotAuthentication(QNetworkReply*, QAuthenticator*) () #25 0x00007ffff7b79092 in OCC::HttpCredentials::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) () #27 0x00007ffff45dd607 in QMetaObject::activate #28 0x00007ffff4e1d6fb in QNetworkAccessManager::authenticationRequired #29 0x00007ffff4e1ea07 in QNetworkAccessManagerPrivate::authenticationRequired #30 0x00007ffff4e3c784 in QNetworkReplyHttpImplPrivate::httpAuthenticationRequired Another case of Main Thread: #5 0x00007ffff4e1edd3 in QNetworkAccessManagerPrivate::clearCache #6 0x00007ffff7b6fb03 in OCC::HttpCredentials::invalidateToken() #7 0x000000000057b1e4 in OCC::AccountState::slotInvalidCredentials() () #8 0x00000000005abb8a in OCC::AccountState::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) () #9 0x00007ffff45dcd30 in QMetaObject::activate #10 0x00007ffff7b76ed5 in OCC::Account::invalidCredentials() () #11 0x00007ffff7ad55f5 in OCC::Account::handleInvalidCredentials() #12 0x00007ffff7afa69a in OCC::AbstractNetworkJob::slotFinished() #13 0x00007ffff7b7654d in OCC::AbstractNetworkJob::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) () #15 0x00007ffff45dd607 in QMetaObject::activate #16 0x00007ffff4edd143 in QNetworkReply::finished #17 0x00007ffff4e3fec7 in QNetworkReplyHttpImplPrivate::finished #18 0x00007ffff4e41818 in QNetworkReplyHttpImpl::close #19 0x00007ffff7b7047b in OCC::HttpCredentials::slotAuthentication(QNetworkReply*, QAuthenticator*) () #20 0x00007ffff7b79092 in OCC::HttpCredentials::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) () #22 0x00007ffff45dd607 in QMetaObject::activate #23 0x00007ffff4e1d6fb in QNetworkAccessManager::authenticationRequired

Add compilestep CI

ghost assigned dragotin Oct 23, 2012

ghost assigned danimo Oct 23, 2012

reinerj mentioned this issue Nov 27, 2012

Fedora owncloud-client-1.1.2-4.1.x86_64 crash #111

Closed

Burtan mentioned this issue Jan 17, 2013

Pausing sync causes crash #245

Closed

danimo mentioned this issue Feb 3, 2013

Upgrading for Retina Displays #307

Closed

beckerfj mentioned this issue Feb 25, 2013

v1.2 Debian Squeeze Sync Client crashing on sync #354

Closed

sghebuz mentioned this issue Mar 11, 2013

Owncloud-client 1.2.1-4.1 crashes on Fedora 18 and 17 (backtrace included) #421

Closed

jochenwezel mentioned this issue Apr 5, 2013

Sync Client V1.2.3 Crashes Repetitively #498

Closed

a-schild mentioned this issue Apr 13, 2013

Crash with 1.2.4-1 on ubuntu 64 bit #536

Closed

chrwen81 mentioned this issue May 15, 2013

1.2.5-1 high CPU and RAM usage #591

Closed

danimo mentioned this issue Sep 6, 2013

HiDPI Support #953

Closed

jozefcernak mentioned this issue Sep 22, 2013

client unknown status, client shows wrong status of synchronization, it is not possible to recover synchronization #1027

Closed

monreal mentioned this issue Nov 2, 2013

Segmentation fault in 1.4.2 #1134

Closed

ghost mentioned this issue Jan 3, 2014

[1.5.0] Seg fault when running on Debian 7.0. #1327

Closed

danimo mentioned this issue Feb 12, 2014

Packages should be built with Qt5 #1418

Closed

MarcelWaldvogel mentioned this issue Apr 10, 2014

OS X 1.6.0 Beta 1 crash on run #1657

Closed

supportreq mentioned this issue Apr 22, 2014

MAC client crashes after launch #1703

Closed

a-schild mentioned this issue May 7, 2014

Windows Client: 1.6.0 beta1 - Crashes very often #1671

Closed

danimo mentioned this issue Jul 2, 2014

OS X menubar icon: Polish design #1730

Closed

oriolmirosa mentioned this issue Jul 25, 2014

[SSL] Mac crash in PROPFIND on large new folder sync #1964

Closed

danimo added the ReadyToTest QA, please validate the fix/enhancement label Feb 12, 2015

labkode mentioned this issue Feb 17, 2015

1.8beta1 core dump #2852

Closed

luciamaestro removed the ReadyToTest QA, please validate the fix/enhancement label Feb 19, 2015

piratenpanda mentioned this issue Apr 6, 2015

Nautilus crashes when creating new folder in owncloud folder and renaming it #3067

Closed

yason mentioned this issue Jul 14, 2015

owncloudclient-1.8.3 crashes on OpenBSD #3456

Closed

Germano0 mentioned this issue Aug 24, 2015

11:0: Function call in the frame header misses mandatory "at file.c:xy" section #3666

Closed

gjanssens mentioned this issue Aug 25, 2015

owncloud-client 1.8.4 crashes on Fedora 22 since qt5 update to 5.5.0 #3679

Closed

mocolini mentioned this issue Sep 7, 2015

[Linux][Qt 5.5.0][Slackware, KDE Plasma 5.4.0] Segfault at application startup. #3769

Closed

marcorighi mentioned this issue Nov 9, 2015

[Linux] [Qt 4.8.6] Owncloud client 2.0.2-3 segmentation fault #4090

Closed

jgleissner mentioned this issue Nov 10, 2015

[2.0.2] [Qt4] [Linux SLE 12] Crashes on startup if configured URL is wrong #4106

Closed

toadhall mentioned this issue Mar 1, 2016

[Linux] [Debian] [2.1.1] owncloud client seg fault in Wizard in libproxy - SOLVED #4525

Closed

dev4223 mentioned this issue Aug 29, 2016

owncloud client segmentation fault on start #5144

Closed

jjanarnava mentioned this issue Oct 2, 2016

[2.2.4] OpenSuse KDE and XFCE Sync: Segfault on start #5218

Closed

dnacombo mentioned this issue Feb 23, 2017

[2.3rc1] Linux client freezing after a few clicks #5557

Closed

peteruithoven mentioned this issue Jun 5, 2017

Icon request: OwnCloud Manuel-Kehl/elementaryPlus#243

Closed

juliusknorr pushed a commit to juliusknorr/client that referenced this issue Aug 6, 2017

Merge pull request owncloud#11 from nextcloud/drone

5e5283a

Add compilestep CI

jnweiger mentioned this issue Jun 7, 2021

[QA] Client crash after account removal #8690

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Retina/HiRes icon support #11

Retina/HiRes icon support #11

LukasReschke commented Oct 23, 2012

danimo commented Oct 23, 2012

danimo commented Oct 23, 2012

jancborchardt commented Apr 30, 2013

danimo commented Apr 7, 2014

ladrua commented Sep 10, 2014

LukasReschke commented Oct 9, 2014

LukasReschke commented Oct 9, 2014

jancborchardt commented Oct 10, 2014

jancborchardt commented Oct 21, 2014

mcmanimie commented Nov 26, 2014

danimo commented Feb 12, 2015

LukasReschke commented Feb 12, 2015

danimo commented Feb 12, 2015

LukasReschke commented Feb 12, 2015

danimo commented Feb 12, 2015

jancborchardt commented Feb 13, 2015

dragotin commented Feb 13, 2015

LukasReschke commented Feb 13, 2015

pulse00 commented Feb 13, 2015

jancborchardt commented Feb 16, 2015

danimo commented Feb 16, 2015

jancborchardt commented Feb 16, 2015

Retina/HiRes icon support #11

Retina/HiRes icon support #11

Comments

LukasReschke commented Oct 23, 2012

danimo commented Oct 23, 2012

danimo commented Oct 23, 2012

jancborchardt commented Apr 30, 2013

danimo commented Apr 7, 2014

ladrua commented Sep 10, 2014

LukasReschke commented Oct 9, 2014

LukasReschke commented Oct 9, 2014

jancborchardt commented Oct 10, 2014

jancborchardt commented Oct 21, 2014

mcmanimie commented Nov 26, 2014

danimo commented Feb 12, 2015

LukasReschke commented Feb 12, 2015

danimo commented Feb 12, 2015

LukasReschke commented Feb 12, 2015

danimo commented Feb 12, 2015

jancborchardt commented Feb 13, 2015

dragotin commented Feb 13, 2015

LukasReschke commented Feb 13, 2015

pulse00 commented Feb 13, 2015

jancborchardt commented Feb 16, 2015

danimo commented Feb 16, 2015

jancborchardt commented Feb 16, 2015