Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle propfind replies with status 425 as valid. #10103

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Handle propfind replies with status 425 as valid. #10103

merged 1 commit into from
Oct 5, 2022

Conversation

dragotin
Copy link
Contributor

With the async upload some entries might have a status code 425 which is a valid code.

@dragotin dragotin changed the title Handle propfind replies with status 425 as valid. [do not merge] Handle propfind replies with status 425 as valid. Sep 12, 2022
@dragotin
Copy link
Contributor Author

There might be more places where changes are needed.

@fmoc fmoc marked this pull request as draft September 13, 2022 12:03
@TheOneRing TheOneRing added this to the 3.0 milestone Sep 14, 2022
@TheOneRing TheOneRing added the p1-urgent Consider a hotfix release with only that fix (ex: lose trust, money, security issue, ...) label Oct 4, 2022
@felix-schwarz felix-schwarz mentioned this pull request Oct 4, 2022
Open
@jesmrec jesmrec mentioned this pull request Oct 4, 2022
Closed
@dragotin @TheOneRing
Handle propfind replies with status 425 as valid.
ae1f2bc 
With the async upload some entries might have a status code 425
which is a valid code.
@TheOneRing TheOneRing changed the title [do not merge] Handle propfind replies with status 425 as valid. Handle propfind replies with status 425 as valid. Oct 5, 2022
@TheOneRing TheOneRing marked this pull request as ready for review October 5, 2022 14:28
@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@TheOneRing TheOneRing merged commit 0c4d4d7 into master Oct 5, 2022
@delete-merged-branch delete-merged-branch bot deleted the handleStatus425 branch October 5, 2022 15:09
@ownclouders
Copy link
Contributor

Results for GUI-tests https://drone.owncloud.com/owncloud/client/13326/6/1

💥 The GUI tests failed.

GUI Logs: https://cache.owncloud.com/public/owncloud/client/13326/guiReportUpload/index.html

Server Logs: https://cache.owncloud.com/public/owncloud/client/13326/guiReportUpload/serverlog.log

Screenshots:

@michaelstingl michaelstingl mentioned this pull request Oct 18, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
p1-urgent Consider a hotfix release with only that fix (ex: lose trust, money, security issue, ...)
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dragotin @ownclouders @TheOneRing