Fix icon name in desktop file with ownBrander themes #9150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changelog and the linked issue pls |
fmoc
force-pushed
the
work/fix-linux-icons
branch
from
bab539e
to
1c1c2e2
Compare
Fixes broken icon reference in desktop entries for some branded build themes. The icon files are not named by the executable name, but by the short name.
fmoc
force-pushed
the
work/fix-linux-icons
branch
from
1c1c2e2
to
4bcd29b
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The icon files in the ownBrander themes are not named by the executable name, but by the short name. The theme included in this repository defines a custom icon name.
Related: #8992 (might even be closed)