Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure to raise the ssl dialog #9375

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Ensure to raise the ssl dialog #9375

merged 1 commit into from
Jan 19, 2022

Conversation

TheOneRing
Copy link
Member

No description provided.

@TheOneRing TheOneRing requested a review from a team January 18, 2022 12:59
@sonarcloud
Copy link

sonarcloud bot commented Jan 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@TheOneRing TheOneRing merged commit ae479bc into 2.10 Jan 19, 2022
@delete-merged-branch delete-merged-branch bot deleted the work/ssl_top branch January 19, 2022 12:47
@TheOneRing TheOneRing mentioned this pull request Mar 10, 2022
Closed
55 tasks
@Talank
Copy link
Contributor

Talank commented Mar 23, 2022

I am not sure what to test here. The changelog says Under certain conditions it was possible that the ssl dialog was hidden behind the wizard. But what are these "certain conditions"?

@TheOneRing
Copy link
Member Author

Lets mark that one as untestable, it was more a theoretic discovery that it could happen, however I don't think I experienced the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmoc fmoc fmoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheOneRing @Talank @fmoc