Leave password line edit enabled on errors #9508
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #9336.
New behavior:
I think we shouldn't disable the close button, because that'll bloat the (already relatively complex) code within the dialog, and requires the user to uncheck the checkbox first (in that case, we'd actually have to disable the close button generally when information is missing to make the UX consistent). Just removing the password and asking for a new one in the line edit combined with displaying the error message gives the user sufficient feedback to continue. Keeping the password makes little sense either, we should not store secrets for longer than necessary.
Upon success, a generic placeholder will be inserted in the line edit, as before.