Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leave password line edit enabled on errors #9508

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Leave password line edit enabled on errors #9508

merged 1 commit into from
Mar 11, 2022

Conversation

fmoc
Copy link
Contributor

@fmoc fmoc commented Mar 11, 2022

Contributes to #9336.

New behavior:

screenshot_2022-03-11_10-53-21

I think we shouldn't disable the close button, because that'll bloat the (already relatively complex) code within the dialog, and requires the user to uncheck the checkbox first (in that case, we'd actually have to disable the close button generally when information is missing to make the UX consistent). Just removing the password and asking for a new one in the line edit combined with displaying the error message gives the user sufficient feedback to continue. Keeping the password makes little sense either, we should not store secrets for longer than necessary.

Upon success, a generic placeholder will be inserted in the line edit, as before.

@fmoc fmoc added this to the 2.10.1 milestone Mar 11, 2022
@fmoc fmoc requested a review from a team March 11, 2022 09:58
@sonarcloud
Copy link

sonarcloud bot commented Mar 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@TheOneRing
Copy link
Member

Could you also check for the expiration date, I think it will also be disabled on invalid input (if it is possible to put in invalid values)

@fmoc
Copy link
Contributor Author

fmoc commented Mar 11, 2022

The format is enforced by the picker. For instance, with the en locale, a short format mm/dd/YY is used. You cannot enter invalid characters, I haven't managed to generate an error message.

(By the way, I don't like abbreviated years in date specifications... perhaps we should change that in a future release.)

@fmoc fmoc merged commit bf5bb0e into 2.10 Mar 11, 2022
@delete-merged-branch delete-merged-branch bot deleted the work/issue-9336 branch March 11, 2022 11:25
@gabi18 gabi18 mentioned this pull request Mar 15, 2022
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants