Fix filter menus #9513
Merged
Fix filter menus #9513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjv
force-pushed
the
work/fix-filter-popup
branch
2 times, most recently
from
ef43f34
to
399acdf
Compare
|
No filter: 1 filter: |
TheOneRing
reviewed
Mar 11, 2022
TheOneRing
reviewed
Mar 11, 2022
erikjv
force-pushed
the
work/fix-filter-popup
branch
from
55b0dbe
to
24e839c
Compare
TheOneRing
reviewed
Mar 11, 2022
| - replaced "No filter" option text with "All", to avoid the "No filter is not enabled" situation | ||
| - replace the "Filter" label on the button with "1 Filter"/"2 Filters" when a filter is active, so a user can immediately see that without having to open the filter pop-up | ||
|
|
||
| https://github.com/owncloud/client/issues/9425 |
There was a problem hiding this comment.
Maybe merge the entry with 9425?
erikjv
force-pushed
the
work/fix-filter-popup
branch
from
24e839c
to
d3fb638
Compare
erikjv
force-pushed
the
work/fix-filter-popup
branch
from
d3fb638
to
b4a6fc4
Compare
|
sigh. something weird happened with this MR. Should be fine now. |
erikjv
force-pushed
the
work/fix-filter-popup
branch
from
1155ee1
to
2bb811b
Compare
TheOneRing
reviewed
Mar 14, 2022
src/gui/protocolwidget.cpp
Outdated
| QString ProtocolWidget::filterButtonText(int filterCount) | ||
| { | ||
| if (filterCount == 0) { | ||
| return tr("Filter"); |
There was a problem hiding this comment.
erikjv
force-pushed
the
work/fix-filter-popup
branch
from
2bb811b
to
cee58b0
Compare
- replaced "No filter" option text with "All", to avoid the "No filter is not enabled" situation - replace the "Filter" label on the button with "1 Filter"/"2 Filters" when a filter is active, so a user can immediately see that without having to open the filter pop-up
erikjv
force-pushed
the
work/fix-filter-popup
branch
from
cee58b0
to
3e3b3a5
Compare
|
Please retry analysis of this Pull-Request directly on SonarCloud. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is not enabled" situation
when a filter is active, so a user can immediately see that without
having to open the filter pop-up