Skip to content

Commit b38a1ad

Browse files
committed
Files: Fix XSS when creating dropshadow
1 parent a5978ad commit b38a1ad

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

apps/files/js/files.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -859,9 +859,9 @@ var createDragShadow = function(event){
859859
var dir=$('#dir').val();
860860

861861
$(selectedFiles).each(function(i,elem){
862-
var newtr = $('<tr data-dir="'+dir+'" data-filename="'+elem.name+'">'
863-
+'<td class="filename">'+elem.name+'</td><td class="size">'+humanFileSize(elem.size)+'</td>'
864-
+'</tr>');
862+
var newtr = $('<tr/>').attr('data-dir', dir).attr('data-filename', elem.name);
863+
newtr.append($('<td/>').addClass('filename').text(elem.name));
864+
newtr.append($('<td/>').addClass('size').text(humanFileSize(elem.size)));
865865
tbody.append(newtr);
866866
if (elem.type === 'dir') {
867867
newtr.find('td.filename').attr('style','background-image:url('+OC.imagePath('core', 'filetypes/folder.png')+')');

0 commit comments

Comments
 (0)